Skip to content

Obliterate nouveau_encoder->crtc

Lyude Paul dri-devel lkml nouveau sashiko-reviews stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesIn review
  2. v16 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/nouveau/kms/nv50-: Move DPCD backlight disable into its own functiondrivers/gpu/drm/nouveau/dispnv50/disp.c+27 -121 reply
2/6drm/nouveau/kms/nv50-: Add nv50_outp_get_old_crtc()drivers/gpu/drm/nouveau/dispnv50/disp.c+16 -00 replies
3/6drm/nouveau/kms/nv50-: Stop using nv_encoder->crtc in nv50_sor_atomic_disable()drivers/gpu/drm/nouveau/dispnv50/disp.c+8 -20 replies
4/6drm/nouveau/kms/nv50-: Stop using nv_encoder->crtc in nv50_disp_atomic_commit_core()drivers/gpu/drm/nouveau/dispnv50/disp.c+2 -10 replies
5/6drm/nouveau/kms/nv50-: Add nouveau_encoder->audio.crtcdrivers/gpu/drm/nouveau/dispnv50/disp.c drivers/gpu/drm/nouveau/nouveau_encoder.h+4 -11 reply
6/6drm/nouveau/kms/nv50-: Obliterate nouveau_encoder->crtcdrivers/gpu/drm/nouveau/dispnv50/disp.c drivers/gpu/drm/nouveau/nouveau_encoder.h+0 -111 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] Obliterate nouveau_encoder->crtc

This is mostly a leftover artifact from the pre-atomic days, and while we've been using it for a while now - it isn't great. Mostly because having redundant state tracking for things atomic already keeps track of is pretty much always error prone, as anyone working on nouveau who isn't already very well versed in atomic modesetting isn't going to realize this isn't the right way to see what CRTC is assigned to an encoder.

Also - this patch series does fix an actual bug (patches 1-3).

Previous version of this patch series:

	https://patchwork.freedesktop.org/series/172417/

Lyude Paul (6):
drm/nouveau/kms/nv50-: Move DPCD backlight disable into its own
function
drm/nouveau/kms/nv50-: Add nv50_outp_get_old_crtc() drm/nouveau/kms/nv50-: Stop using nv_encoder->crtc in

    nv50_sor_atomic_disable()
  drm/nouveau/kms/nv50-: Stop using nv_encoder->crtc in
    nv50_disp_atomic_commit_core()

drm/nouveau/kms/nv50-: Add nouveau_encoder->audio.crtc drm/nouveau/kms/nv50-: Obliterate nouveau_encoder->crtc

 drivers/gpu/drm/nouveau/dispnv50/disp.c   | 78 ++++++++++++++++-------
 drivers/gpu/drm/nouveau/nouveau_encoder.h |  4 +-
 2 files changed, 56 insertions(+), 26 deletions(-)

base-commit: 0e118b936dc5904cf0d9859882a40c96057b083d

Signature · 1 line
2.55.0