Skip to content

auxdisplay: add devm_linedisp_register() and fix work initialization races

[email protected] lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3auxdisplay: line-display: add devm_linedisp_register()drivers/auxdisplay/line-display.c drivers/auxdisplay/line-display.h+34 -01 reply
2/3auxdisplay: seg-led-gpio: fix work initialization race and convert to devm_linedisp_register()drivers/auxdisplay/seg-led-gpio.c+14 -130 replies
3/3auxdisplay: max6959: fix work initialization race and convert to devm_linedisp_register()drivers/auxdisplay/max6959.c+13 -131 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchChris Packham
1/3
2/3R-b T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] auxdisplay: add devm_linedisp_register() and fix work initialization races

From: Surendra Singh Chouhan <[email protected]>

Per maintainer review feedback from Andy Shevchenko and Chris Packham, this patch series introduces a devm-managed devm_linedisp_register() helper for the line-display core to avoid use-after-free teardown races across auxdisplay drivers.

Patch 1 adds devm_linedisp_register() to line-display core.

Patch 2 fixes delayed work initialization races in seg-led-gpio.c, moves INIT_DELAYED_WORK() to probe(), uses devm_add_action_or_reset() for work cancellation, and converts to devm_linedisp_register(), removing seg_led_remove().

Patch 3 fixes delayed work initialization races in max6959.c, moves INIT_DELAYED_WORK() to probe(), uses devm_add_action_or_reset() for work cancellation, and converts to devm_linedisp_register(), removing max6959_i2c_remove().

Surendra Singh Chouhan (3):
auxdisplay: line-display: add devm_linedisp_register()
auxdisplay: seg-led-gpio: fix work initialization race and convert to
devm_linedisp_register()
auxdisplay: max6959: fix work initialization race and convert to
devm_linedisp_register()

 drivers/auxdisplay/line-display.c | 32 +++++++++++++++++++++++++++++++
 drivers/auxdisplay/line-display.h |  2 ++
 drivers/auxdisplay/max6959.c      | 26 ++++++++++++-------------
 drivers/auxdisplay/seg-led-gpio.c | 27 +++++++++++++-------------
 4 files changed, 61 insertions(+), 26 deletions(-)
Signature · 1 line
2.55.0