Skip to content

ksmbd: bound smb_check_perm_dacl() ACE walks by DACL size

[email protected] linux-cifs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest3 patches 1 replyIn review

Changes in v3 from the cover letter

- Update SMB_SERVER_KUNIT_TESTS help text.
- Moved kunit tests under fs/smb/server/tests/.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ksmbd: add KUnit test for the DACL walk boundaryfs/smb/server/Kconfig fs/smb/server/Makefile fs/smb/server/tests/Kconfig +2 more+192 -00 replies
2/3ksmbd: test smb_check_perm_dacl() DACL walk boundaryfs/smb/server/smbacl.c fs/smb/server/tests/smbacl_kunit.c fs/smb/server/vfs.c+94 -00 replies
3/3ksmbd: test maximal-access DACL walk boundaryfs/smb/server/tests/smbacl_kunit.c+44 -30 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChenXiaoSong
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] ksmbd: bound smb_check_perm_dacl() ACE walks by DACL size

From: Hang Nan <[email protected]>

Changes in v3:

- Update SMB_SERVER_KUNIT_TESTS help text.
- Moved kunit tests under fs/smb/server/tests/.

The following patch from v2 have already been merged into #ksmbd-for-next-next:
https://lore.kernel.org/linux-cifs/CAKYAXd9XHJSNfrFr+F8thNxFnXqGGcKpS1b1qR4DNuu82+j_VQ@mail.gmail.com/

Hang Nan (3):
ksmbd: add KUnit test for the DACL walk boundary
ksmbd: test smb_check_perm_dacl() DACL walk boundary
ksmbd: test maximal-access DACL walk boundary

 fs/smb/server/Kconfig              |   2 +
 fs/smb/server/Makefile             |   1 +
 fs/smb/server/smbacl.c             |   2 +
 fs/smb/server/tests/Kconfig        |  15 ++
 fs/smb/server/tests/Makefile       |   4 +
 fs/smb/server/tests/smbacl_kunit.c | 301 +++++++++++++++++++++++++++++
 fs/smb/server/vfs.c                |   2 +
 7 files changed, 327 insertions(+)
 create mode 100644 fs/smb/server/tests/Kconfig
 create mode 100644 fs/smb/server/tests/Makefile
 create mode 100644 fs/smb/server/tests/smbacl_kunit.c
Signature · 1 line
2.55.0