Skip to content

Hexagon: fix icinva

Brian Cain qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2target/hexagon: invalidate translated code for user icinvatarget/hexagon/gen_tcg.h target/hexagon/helper.h target/hexagon/op_helper.c +1 more+31 -04 replies
2/2tests/tcg/hexagon: add icinva testtests/tcg/hexagon/Makefile.target tests/tcg/hexagon/icinva.c+73 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPierrick Bouvier
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Hexagon: fix icinva

icinva (icache invalidate addr) instruction was a nop, but this behavior is not correct for userspace.

Also note that this checkpatch issue was bypassed because I believe it's appropriate/acceptable to check the "guest" page size in a TCG test case.

Patch 1/2 has no obvious style problems and is ready for submission. 2/2 Checking commit ea94abbfc875 (tests/tcg/hexagon: add icinva test)
ERROR: use qemu_real_host_page_size() instead of sysconf(_SC_PAGESIZE) #74: FILE: tests/tcg/hexagon/icinva.c:56:
+ long pagesize = sysconf(_SC_PAGESIZE);

Brian Cain (2):
target/hexagon: invalidate translated code for user icinva tests/tcg/hexagon: add icinva test

 target/hexagon/gen_tcg.h          |  9 ++++
 target/hexagon/helper.h           |  4 ++
 target/hexagon/op_helper.c        | 15 +++++++
 target/hexagon/translate.c        |  3 ++
 tests/tcg/hexagon/icinva.c        | 71 +++++++++++++++++++++++++++++++
 tests/tcg/hexagon/Makefile.target |  2 +
 6 files changed, 104 insertions(+)
 create mode 100644 tests/tcg/hexagon/icinva.c
Signature · 1 line
2.34.1