Skip to content

Handle an empty IMAGE_LINK_NAME consistently

Thomas Roos openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest5 patches 4 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5sbom-cve-check: read the image SBOM through the stable symlinkmeta/classes-recipe/sbom-cve-check.bbclass+2 -10 replies
2/5vex: skip the VEX symlink when IMAGE_LINK_NAME is emptymeta/classes/vex.bbclass+2 -12 replies
3/5testexport: fall back to IMAGE_NAME when IMAGE_LINK_NAME is emptymeta/classes-recipe/testexport.bbclass+1 -10 replies
4/5image_types: skip multiubi symlinks when IMAGE_LINK_NAME is emptymeta/classes-recipe/image_types.bbclass+1 -10 replies
5/5oeqa/selftest/imagefeatures: test an empty IMAGE_LINK_NAMEmeta/lib/oeqa/selftest/cases/imagefeatures.py+42 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] Handle an empty IMAGE_LINK_NAME consistently

v1 fixed the sbom-cve-check input path. Paul noted that 2a80840a4fe0 ("sbom-cve-check: Fix breakage with empty IMAGE_LINK_NAME") had already touched this class, and that other classes make the same assumption. That commit guarded the export symlinks; the input path is separate and still built from IMAGE_NAME. Patch 1 now uses the shape Paul suggested, and patches 2-4 fix the other sites found by auditing meta/classes*, meta/lib/oe and meta/lib/oeqa.

Read and write sites need opposite handling of an empty value: read sites fall back to IMAGE_NAME, write sites skip the link. A central default (pin IMAGE_LINK_NAME to IMAGE_NAME when empty) does not work, as create_symlinks and multiubi_mkfs have no link != target check and IMAGE_NAME is itself derived from IMAGE_LINK_NAME.

Tested on qemux86-64, each fix confirmed in both directions. Patch 5 covers patches 2-4 in one build; patch 1 was checked by hand, as a selftest would need the sbom-cve-check databases (~8.7G of git).

AI-Generated: Uses Claude Opus 5

Thomas Roos (5):
sbom-cve-check: read the image SBOM through the stable symlink
vex: skip the VEX symlink when IMAGE_LINK_NAME is empty
testexport: fall back to IMAGE_NAME when IMAGE_LINK_NAME is empty
image_types: skip multiubi symlinks when IMAGE_LINK_NAME is empty oeqa/selftest/imagefeatures: test an empty IMAGE_LINK_NAME

 meta/classes-recipe/image_types.bbclass       |  2 +-
 meta/classes-recipe/sbom-cve-check.bbclass    |  3 +-
 meta/classes-recipe/testexport.bbclass        |  2 +-
 meta/classes/vex.bbclass                      |  3 +-
 meta/lib/oeqa/selftest/cases/imagefeatures.py | 42 +++++++++++++++++++
 5 files changed, 48 insertions(+), 4 deletions(-)
Signature · 1 line
2.55.0