KVM: arm64: vgic-its: Make the ITS table save reliable
Status from this message: Applied to fixes, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 6 repliesApplied
- v14 patches 5 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | KVM: arm64: vgic-its: Free the caches when GITS_BASER changesarch/ | +8 | 3 replies | |
| 2/4 | Revert "KVM: arm64: vgic-its: Don't save collections the table cannot hold"arch/ | +0 | 0 replies | |
| 3/4 | KVM: arm64: vgic-its: Skip unreachable devices instead of failing the savearch/ | +19 | 0 replies | |
| 4/4 | KVM: arm64: selftests: Add ITS table save teststools/ tools/ | +442 | 1 reply |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Marc Zyngier |
|---|---|
| Series | R-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] KVM: arm64: vgic-its: Make the ITS table save reliable
Hi folks,
Changes since v1 [1]:
- Free the LPI translation cache in vgic_mmio_write_its_baser() too, inside the its_lock section. (Eric)
- Reworded patch 1 to name the register the write is to. (Eric)
- Rebased onto kvmarm/next.
Marc pointed out on the v2 ITS series [2] that patch 3 fixed the wrong end of the problem: KVM should drop the collections when the guest changes the table that described them, rather than validating them at save time. He also called that patch's -EINVAL a mistake, since it aborts a save userspace has to be able to issue. This series does both, following his answers [3] to the two open questions: purge the whole list, and skip the offending device rather than fail.
vgic_mmio_write_its_baser() now frees the cached devices or collections whenever the stored register value changes, not only when VALID is cleared, and drops the translation cache with them. It tests for a change rather than a write because the ITS driver rewrites an unchanged GITS_BASER<n> on resume. With that in place the check patch 3 added is unreachable, so it is reverted, and vgic_its_save_device_tables() skips a device the table can no longer address instead of failing the save.
compute_next_devid_offset() now calls vgic_its_check_id(), which reads guest memory for an indirect table, so the save does 2n reads rather than n. It stays linear, as the scan stops at the first reachable successor. Patch 1's Fixes: tag names a v4.15 commit, so it will be picked up for stable. Drop the tag if that is not wanted.
Patches 1 and 3 apply to v7.2 unchanged, but patch 2 reverts a commit only in kvmarm/next, so the series is based there.
Tested on QEMU: the new selftest, vgic_irq, vgic_lpi_stress and boots. Both cases of the new selftest reset and restore the tables they saved, and both fail without the series.
Based on kvmarm/next (aa8e5dc6a7a2a).
Cheers,
/fuad
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/all/[email protected]/
Fuad Tabba (4):
KVM: arm64: vgic-its: Free the caches when GITS_BASER changes Revert "KVM: arm64: vgic-its: Don't save collections the table cannot
hold"
KVM: arm64: vgic-its: Skip unreachable devices instead of failing the
save
KVM: arm64: selftests: Add ITS table save tests
arch/arm64/kvm/vgic/vgic-its.c | 46 +- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../selftests/kvm/arm64/vgic_its_save.c | 441 ++++++++++++++++++ 3 files changed, 469 insertions(+), 19 deletions(-) create mode 100644 tools/testing/selftests/kvm/arm64/vgic_its_save.c
Signature · 1 line
2.39.5