Skip to content

RFC x86/resctrl: Refactor resctrl enumeration

Tony Luck linux-patches lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86/resctrl: Check if monitoring features are enabledarch/x86/kernel/cpu/resctrl/core.c+3 -04 replies
2/4x86/resctrl: Enumerate monitor features in rdt_get_l3_mon_config()arch/x86/include/asm/resctrl.h arch/x86/kernel/cpu/resctrl/monitor.c+33 -80 replies
3/4x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config()arch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c+23 -180 replies
4/4x86/resctrl: Delete resctrl_cpu_detect()arch/x86/include/asm/processor.h arch/x86/include/asm/resctrl.h arch/x86/kernel/cpu/amd.c +3 more+0 -621 reply

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchBorislav Petkov (AMD)
1/4
2/4
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/4] x86/resctrl: Refactor resctrl enumeration

This series is posted as RFC to get some feedback before I incorporate it into the next version of my patches to fix Kconfig issues[1]. It was prompted by Reinette's comment[2]:

"It looks to me that moving monitoring enumeration done in resctrl_cpu_detect()
into resctrl proper where the RMID range checks can be centralized on features gated by rdt_cpu_has() would be simpler and accurate?"

Patch 1 adds a missing test that RDT monitoring is enabled in any form. This test has been missing from the very start of Linux implementation. I added a Fixes: tag abd it could be backported to stable and long term kernels, but there might not be much value in doing so.

The remaining patches just relocate the enumeration from an early call on the BSP, to the appropriate point in the normal "late_init" initialization of resctrl. No functional changes intended in these patches.

Tony Luck (4):
x86/resctrl: Check if monitoring features are enabled x86/resctrl: Enumerate monitor features in rdt_get_l3_mon_config() x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config() x86/resctrl: Delete resctrl_cpu_detect()

 arch/x86/include/asm/processor.h       |  4 --
 arch/x86/include/asm/resctrl.h         | 12 ++---
 arch/x86/kernel/cpu/resctrl/internal.h |  4 +-
 arch/x86/kernel/cpu/amd.c              |  3 --
 arch/x86/kernel/cpu/hygon.c            |  3 --
 arch/x86/kernel/cpu/intel.c            |  7 ---
 arch/x86/kernel/cpu/resctrl/core.c     | 47 ++----------------
 arch/x86/kernel/cpu/resctrl/monitor.c  | 67 +++++++++++++++++++-------
 8 files changed, 59 insertions(+), 88 deletions(-)

base-commit: bd5f485f3f026225b86573e559af0b7254ef4184

Signature · 1 line
2.55.0