ASoC: mediatek: mt8186: Fix clock error handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest posting 2/28 patches 1 replyIn review
- v4 posting 1/25 patches 2 repliesSuperseded
- v3 posting 2/28 patches 0 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 1/2 | 5 patches | 3 replies | Superseded | |
| v2 posting 2/2 | 4 patches | 0 replies | Superseded | |
| v2 posting 1/2 | 4 patches | 7 replies | Superseded | |
| v1 | 5 patches | 1 reply | Superseded |
Changes in v4 from the cover letter
- In the mux disable path, remove the goto labels so that all teardown steps are attempted and any errors are only reported.
Patches in v4 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | ASoC: mediatek: mt8186: Fix APLL mux setting error handlingsound/ | +38 | 0 replies | |
| 2/8 | ASoC: mediatek: mt8186: Fix clock handling in mux disable pathsound/ | +0 | 0 replies | |
| 3/8 | ASoC: mediatek: mt8186: Fix AFE clock error handlingsound/ | +8 | 0 replies | |
| 4/8 | ASoC: mediatek: mt8186: Fix APLL enable error handlingsound/ | +10 | 0 replies | |
| 5/8 | ASoC: mediatek: mt8186: Fix MCK error handlingsound/ | +13 | 0 replies | |
| 6/8 | ASoC: mediatek: mt8186: Fix gpio rollback on adda dl/ul partial failuresound/ | +5 | 0 replies | |
| 7/8 | ASoC: mediatek: mt8186: Handle regcache sync failuresound/ | +5 | 0 replies | |
| 8/8 | ASoC: mediatek: mt8186: Drop redundant probe error messagessound/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 0/8] ASoC: mediatek: mt8186: Fix clock error handling
From: bui duc phuc <[email protected]>
Hi all,
This series fixes several error handling issues in the mt8186 ASoC driver.
The patches mainly address failures during APLL/mux, clock, MCK, GPIO, and regcache operations. In particular, they make sure that partial failures are handled correctly and that resources are left in a consistent state.
The series also removes redundant probe error messages where the errors are already reported by the called functions.
The changes were found by manual code inspection and compile-tested only.
Link v1 :
https://lore.kernel.org/all/[email protected]/
Link v2:
https://lore.kernel.org/all/[email protected]/
Link v3:
https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Update the cover letter.
- Drop patch 5 from v1.
- Add Fixes tags.
Changes in v3:
- Add a patch to fix clock handling in the mux disable path
- Return directly from apllx_mux_setting() instead of using a goto label
- Add GPIO rollback handling for partial failures in ADDA DL/UL.
- Add Handle failures from regcache_sync().
- Add a patch to remove redundant error messages from the probe path.
- Update the cover letter.
Changes in v4:
- In the mux disable path, remove the goto labels so that all teardown steps are attempted and any errors are only reported.
Best regards,
Phuc
bui duc phuc (8):
ASoC: mediatek: mt8186: Fix APLL mux setting error handling
ASoC: mediatek: mt8186: Fix clock handling in mux disable path
ASoC: mediatek: mt8186: Fix AFE clock error handling
ASoC: mediatek: mt8186: Fix APLL enable error handling
ASoC: mediatek: mt8186: Fix MCK error handling
ASoC: mediatek: mt8186: Fix gpio rollback on adda dl/ul partial
failure
ASoC: mediatek: mt8186: Handle regcache sync failure
ASoC: mediatek: mt8186: Drop redundant probe error messages
sound/soc/mediatek/mt8186/mt8186-afe-clk.c | 95 ++++++++++++++------- sound/soc/mediatek/mt8186/mt8186-afe-gpio.c | 6 +- sound/soc/mediatek/mt8186/mt8186-afe-pcm.c | 21 +++-- 3 files changed, 78 insertions(+), 44 deletions(-)
Signature · 1 line
2.43.0