Skip to content

HID: intel-thc-hid: intel-quickspi: two DMA buffer overflows

HyeongJun An linux-input lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2HID: intel-thc-hid: intel-quickspi: size the input buffer for the DMAdrivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c+7 -21 reply
2/2HID: intel-thc-hid: intel-quickspi: bound the GET REPORT response to report_bufdrivers/hid/intel-thc-hid/intel-quickspi/quickspi-protocol.c+10 -22 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchEven Xu
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] HID: intel-thc-hid: intel-quickspi: two DMA buffer overflows

Two heap overflows on the QuickSPI receive path, both from a controller that declares one length and sends another.

The first is the DMA landing buffer, sized from the device descriptor while the THC DMA rounds its packet size up to 4K. The second is the GET REPORT response, whose length is checked against what the DMA delivered and never against report_buf. Each has a sibling in-tree that already gets it right, named in the patch.

Neither was reproduced on hardware. Both turned up while working on commit 035ec4a71cb8 ("HID: intel-thc-hid: intel-quickspi: bound GET_REPORT response to the caller buffer"), which covers neither.

A fuller fix for the first would give thc_rxdma_read() a capacity argument, but that changes a shared API and touches intel-quicki2c, so this keeps to the driver.

HyeongJun An (2):
HID: intel-thc-hid: intel-quickspi: size the input buffer for the DMA
HID: intel-thc-hid: intel-quickspi: bound the GET REPORT response to
report_buf

 .../hid/intel-thc-hid/intel-quickspi/pci-quickspi.c  |  9 +++++++--
 .../intel-thc-hid/intel-quickspi/quickspi-protocol.c | 12 ++++++++++--
 2 files changed, 17 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0