Skip to content

Netfilter fixes for net

Pablo Neira Ayuso netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10netfilter: tproxy: use DEBUG_NET_WARN_ON_ONCE for protocol fallbacksnet/ipv4/netfilter/nf_tproxy_ipv4.c net/ipv6/netfilter/nf_tproxy_ipv6.c+2 -20 replies
2/10netfilter: conncount: use DEBUG_NET_WARN_ON_ONCE on reaching count limitnet/netfilter/nf_conncount.c+2 -10 replies
3/10netfilter: nf_tables: move hardware offload step after building the chain blobnet/netfilter/nf_tables_api.c+10 -40 replies
4/10netfilter: nft_set_pipapo_avx2: add missing vzerouppernet/netfilter/nft_set_pipapo_avx2.c+8 -90 replies
5/10netfilter: x_tables: remove pr_debugnet/ipv4/netfilter/ipt_ah.c net/ipv6/netfilter/ip6t_ah.c net/ipv6/netfilter/ip6t_frag.c +15 more+47 -2462 replies
6/10netfilter: xt_cgroup: use pr_info_ratelimited()net/netfilter/xt_cgroup.c+5 -50 replies
7/10netfilter: nf_tables: skip double clone set expressions on element insertinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nft_dynset.c+33 -502 replies
8/10netfilter: nf_tables: fix device name and prefix match in hook lookupnet/netfilter/nf_tables_api.c+6 -32 replies
9/10netfilter: nf_tables: set on dead bit when performing early element removalnet/netfilter/nf_tables_api.c+4 -00 replies
10/10netfilter: nf_tables: remove leftover set_update_listnet/netfilter/nf_tables_api.c+0 -10 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchStefano Brivio
1/10
2/10
3/10
4/10R-b
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 00/10] Netfilter fixes for net

Hi,

The following patchset contains Netfilter fixes for net:

1) Use DEBUG_NET_WARN_ON_ONCE() instead of WARN_ON() from the tproxy datapath, a recent bug found a way to reach WARN_ON from datapath due to insufficient validation of xt_TPROTO checkentry. From Fernando F. Mancera.

2) Similar to previous patch to replace WARN_ON_ONCE by DEBUG_NET_WARN_ON_ONCE() for connlimit. Not known issue, but since this patch has been around for a while, let's merge it. Also from Fernando.

3) Move nf_tables harware offload commit path after chain blob and audit to reduce chances of leaving the hardware in inconsistent state.

4) Add missing vzeroupper to nf_tables pipapo AVX2 to address performace degradation to later user of SSE code, from Eric Biggers.

5) Remove pr_debug() in x_tables extensions, a recent bogus found a way to print a unsanitized string in xt_IDLETIMER, many of these pr_debug() calls are there for historical reasons.

6) Use pr_info_ratelimited() in x_tables .checkentry.

7) Fix an imbalance in module refcount due to incorrect override expression logic with sets. Remove unnecessary clone in control plane, use the existing expressions provided by set or dynset expression. Release override expressions only.

9) Tigthen nf_tables device name removal, it is possible to remove prefix strings with exact device name. From Fernando F. Mancera.

9) Set on the set dead bit earlier, otherwise it is possible to call .commit on deleted sets. This also addresses the re-introduction of a bug.

10) Remove leftover definition of the local set_update_list. A recent patch made it per-netns but did not remove this which is now unused.

Please, pull these changes from:

git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git nf-26-08-21

Thanks.

----------------------------------------------------------------

The following changes since commit 746fc0787f616da418ffc04a110296fe95d53491:

net: usb: cdc_ncm: add Apple MacBook Pro USB product ID 0x1902 (2026-08-20 14:47:29 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git tags/nf-26-08-21

for you to fetch changes up to 878ca6f9739ab460a185fd1f0e64c8ef026057e4:

netfilter: nf_tables: remove leftover set_update_list (2026-08-21 17:12:59 +0200)

----------------------------------------------------------------
netfilter pull request 26-08-21

----------------------------------------------------------------
Eric Biggers (1):
netfilter: nft_set_pipapo_avx2: add missing vzeroupper

Fernando Fernandez Mancera (3):
netfilter: tproxy: use DEBUG_NET_WARN_ON_ONCE for protocol fallbacks
netfilter: conncount: use DEBUG_NET_WARN_ON_ONCE on reaching count limit
netfilter: nf_tables: fix device name and prefix match in hook lookup

Pablo Neira Ayuso (6):
netfilter: nf_tables: move hardware offload step after building the chain blob
netfilter: x_tables: remove pr_debug
netfilter: xt_cgroup: use pr_info_ratelimited()
netfilter: nf_tables: skip double clone set expressions on element insert
netfilter: nf_tables: set on dead bit when performing early element removal
netfilter: nf_tables: remove leftover set_update_list

 include/net/netfilter/nf_tables.h   |  2 -
 net/ipv4/netfilter/ipt_ah.c         | 10 +----
 net/ipv4/netfilter/nf_tproxy_ipv4.c |  2 +-
 net/ipv6/netfilter/ip6t_ah.c        | 27 +-----------
 net/ipv6/netfilter/ip6t_frag.c      | 41 +-----------------
 net/ipv6/netfilter/ip6t_hbh.c       | 40 ++++--------------
 net/ipv6/netfilter/ip6t_mh.c        |  3 --
 net/ipv6/netfilter/ip6t_rt.c        |  6 +--
 net/ipv6/netfilter/nf_tproxy_ipv6.c |  2 +-
 net/netfilter/nf_conncount.c        |  3 +-
 net/netfilter/nf_tables_api.c       | 84 +++++++++++++++++--------------------
 net/netfilter/nft_dynset.c          | 25 ++++++-----
 net/netfilter/nft_set_pipapo_avx2.c | 17 ++++----
 net/netfilter/xt_IDLETIMER.c        | 68 ++++++------------------------
 net/netfilter/xt_LOG.c              |  4 +-
 net/netfilter/xt_MASQUERADE.c       |  4 +-
 net/netfilter/xt_NETMAP.c           |  4 +-
 net/netfilter/xt_REDIRECT.c         |  4 +-
 net/netfilter/xt_cgroup.c           | 10 ++---
 net/netfilter/xt_esp.c              | 10 +----
 net/netfilter/xt_ipcomp.c           |  8 +---
 net/netfilter/xt_iprange.c          | 32 ++------------
 net/netfilter/xt_ipvs.c             |  1 -
 net/netfilter/xt_multiport.c        |  4 --
 net/netfilter/xt_sctp.c             | 19 +--------
 net/netfilter/xt_tcpudp.c           |  8 +---
 26 files changed, 117 insertions(+), 321 deletions(-)