Skip to content

disable private stack for sleepable programs

Christian Simon bpf stable 1 version NAK

Status from this message: nack.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest2 patches 12 repliesNAK

Changes in v3 from the cover letter

- Target sleepable only.
- Add the powerpc Fixes tag.
- Split fix and selftests

Patches in v3

#Subject and filesSizeRepliesApplied
1/2bpf: disable private stack for sleepable programskernel/bpf/verifier.c+9 -012 replies
2/2selftests/bpf: verify preemptible uprobes avoid private stacktools/testing/selftests/bpf/prog_tests/uprobe_sleepable_stack.c tools/testing/selftests/bpf/progs/uprobe_sleepable_stack.c+254 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH bpf v3 0/2] disable private stack for sleepable programs

A JITed BPF program can use one private stack per program and CPU. Sleepable programs can be preempted, allowing another task to run the same program on the same CPU. The second invocation then reuses and can overwrite the first invocation's private stack.

This patch series disables private stacks for sleepable programs and adds a selftest covering that stack corruption.

---
Changes in v3:
- Target sleepable only.
- Add the powerpc Fixes tag.
- Split fix and selftests

v2: https://lore.kernel.org/bpf/[email protected]/

Christian Simon (2):
bpf: disable private stack for sleepable programs selftests/bpf: verify preemptible uprobes avoid private stack

 kernel/bpf/verifier.c                         |   9 +
 .../bpf/prog_tests/uprobe_sleepable_stack.c   | 165 ++++++++++++++++++
 .../bpf/progs/uprobe_sleepable_stack.c        |  89 ++++++++++
 3 files changed, 263 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/uprobe_sleepable_stack.c
 create mode 100644 tools/testing/selftests/bpf/progs/uprobe_sleepable_stack.c

base-commit: 75b0a6db4300e4c2c9e97a0848deaa7acfb42fb7

Signature · 1 line
2.54.0