Skip to content

ksmbd: fix information leaks in smb2_get_info_filesystem()

Aleksandr Khromov linux-cifs lkml 1 version Applied

Status from this message: Applied it to #ksmbd-for-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 3 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3ksmbd: zero the FS_OBJECT_ID_INFORMATION buffer before filling it infs/smb/server/smb2pdu.c+1 -01 reply
2/3ksmbd: initialize FileSystemControlFlags in FS_CONTROL_INFORMATIONfs/smb/server/smb2pdu.c+1 -01 reply
3/3ksmbd: fill in FileSysIdentifier in FS_POSIX_INFORMATIONfs/smb/server/smb2pdu.c+2 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] ksmbd: fix information leaks in smb2_get_info_filesystem()

smb2_get_info_filesystem() sets rsp->OutputBufferLength to the full size of the structure of the requested info level, but three levels leave part of that structure unwritten:

FS_OBJECT_ID_INFORMATION 31 of 64 bytes (objid[] tail when the volume

                            UUID is unavailable, plus version_string[])

FS_CONTROL_INFORMATION 4 of 48 bytes (FileSystemControlFlags)
FS_POSIX_INFORMATION 8 of 56 bytes (FileSysIdentifier)

The response buffer is zeroed on allocation, so a standalone request returns zeros there. A compound request need not:
work->next_smb2_rsp_hdr_off is advanced by the length pinned for the previous response, so if a command wrote its reply into the buffer and then failed, smb2_set_err_rsp() pins only the short error response and the next reply is laid over the bytes already written. Only the header is cleared at that point:

	memset((char *)rsp_hdr, 0, sizeof(struct smb2_hdr) + 2);

What leaks is not arbitrary kernel memory but a reply that ksmbd built for the same connection and did not send, including one that failed with an access denied error.

Compile tested only (x86_64_defconfig + CONFIG_SMB_SERVER=m).

v2: v1 was a single patch clearing only objid[]. ChenXiaoSong asked in
review whether extended_info.version_string leaks as well; it does, and so do the other two levels, so v2 clears the whole structure in patch 1 and adds patches 2 and 3. All three go back to the original ksmbd import rather than to commit 3a64125730ca ("ksmbd: use volume UUID in FS_OBJECT_ID_INFORMATION"), so the Fixes: tags moved accordingly; on trees without that commit patch 1 needs a trivial context fixup.
v1: https://lore.kernel.org/linux-cifs/[email protected]/

Aleksandr Khromov (3):
ksmbd: zero the FS_OBJECT_ID_INFORMATION buffer before filling it in
ksmbd: initialize FileSystemControlFlags in FS_CONTROL_INFORMATION
ksmbd: fill in FileSysIdentifier in FS_POSIX_INFORMATION

 fs/smb/server/smb2pdu.c | 4 ++++
 1 file changed, 4 insertions(+)
Signature · 1 line
2.48.1