Skip to content

Add many missing _requires

Eric Sandeen fstests 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5generic: remove chmod of $seqres.full filetests/generic/379 tests/generic/384+0 -61 reply
2/5Add _require_chmod as neededtests/generic/093 tests/generic/099 tests/generic/184 +38 more+41 -01 reply
3/5Add _require_chown as neededtests/generic/093 tests/generic/099 tests/generic/105 +28 more+31 -04 replies
4/5Add _require_hardlinks as neededtests/generic/066 tests/generic/084 tests/generic/398 +12 more+15 -01 reply
5/5Add _require_mknod as neededtests/generic/398 tests/generic/598+2 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchZorro Lang
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Add many missing _requires

Many tests take actions (chmod, chown, hardlink, mknod) which may not be supported by simpler filesystems. Often this is fine because other _require tests already cause the _notrun to occur, but this makes it all explicit.

Patch 1 simply removes some spurious "chmod" calls that do not act on the filesystem under test and AFAICT are not necessary.