Skip to content

phy: spacemit: fix and enable the K1 USB 2.0 PHY

Bruno Banelli linux-phy linux-riscv lkml spacemit 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 2 repliesApplied 2/2

Changes in v2 from the cover letter

- new patch 1/2 adding "depends on HAS_IOMEM" and "select REGMAP_MMIO", with a Fixes: tag
- no change to the patch now numbered 2/2

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2phy: spacemit: fix K1 USB 2.0 PHY Kconfig dependenciesdrivers/phy/spacemit/Kconfig+2 -00 repliesApplied
2/2phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMITdrivers/phy/spacemit/Kconfig+1 -00 repliesApplied

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYixun Lan
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] phy: spacemit: fix and enable the K1 USB 2.0 PHY

v1 was a single patch adding "default ARCH_SPACEMIT" to PHY_SPACEMIT_K1_USB2. Automated review pointed out two pre-existing Kconfig problems in the same entry, and that change makes them easier to hit: enabling the symbol by default means configurations that would previously have left it off will now build the driver.

So fix the dependencies first, then enable it by default.

Both were verified against the driver source: phy-k1-usb2.c calls devm_platform_ioremap_resource() and devm_regmap_init_mmio(), while the Kconfig entry has neither "depends on HAS_IOMEM" nor
"select REGMAP_MMIO". PHY_SPACEMIT_K1_PCIE, directly above it in the same file, already has the HAS_IOMEM dependency.

Tested on a Milk-V Jupiter (SpacemiT M1) running mainline 7.2: without patch 2/2 a "make defconfig" kernel has no USB at all, because dwc3-generic-plat cannot get its PHY.

v1: https://lore.kernel.org/linux-riscv/[email protected]/

Changes in v2:
- new patch 1/2 adding "depends on HAS_IOMEM" and "select REGMAP_MMIO", with a Fixes: tag
- no change to the patch now numbered 2/2

Bruno Banelli (2):
phy: spacemit: fix K1 USB 2.0 PHY Kconfig dependencies
phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT

 drivers/phy/spacemit/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91

Signature · 1 line
2.43.0