Skip to content

s390: Warn if kernel command line contains non-printable EBCDIC characters

Ilya Leoshkevich linux-s390 lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v32 patches 2 repliesSuperseded
  3. v21 patch 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch6 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2s390/ebcdic: Add character classes for the ASCII subset of EBCDICarch/s390/include/asm/ebcdic.h arch/s390/kernel/ebcdic.c+45 -10 replies
2/2s390: Warn if kernel command line contains non-printable EBCDIC charactersarch/s390/boot/ipl_parm.c+12 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] s390: Warn if kernel command line contains non-printable EBCDIC characters

v3: https://lore.kernel.org/linux-s390/[email protected]/
v3 -> v4: Switch to ASCII subset of EBCDIC (Sashiko, Heiko).
Add and use isspace_ebc_asc() to satisfy Heiko's comment about newlines in v1.

v2: https://lore.kernel.org/all/[email protected]/
v2 -> v3: Check whether source EBCDIC characters are printable

          (David, Heiko).

v1: https://lore.kernel.org/all/[email protected]/
v1 -> v2: Account for newlines (Heiko).
Minor stylistic improvements: inline int i, bool return type, comment modality.

Hi,

This series adds a warning for unintentional EBCDIC -> ASCII kernel command line translations. Patch 1 adds EBCDIC character classes. Patch 2 uses them for determining whether the command line is printable.

Best regards,
Ilya

Ilya Leoshkevich (2):
s390/ebcdic: Add character classes for the ASCII subset of EBCDIC
s390: Warn if kernel command line contains non-printable EBCDIC
characters

 arch/s390/boot/ipl_parm.c      | 13 ++++++++++-
 arch/s390/include/asm/ebcdic.h |  6 +++++
 arch/s390/kernel/ebcdic.c      | 40 +++++++++++++++++++++++++++++++++-
 3 files changed, 57 insertions(+), 2 deletions(-)
Signature · 1 line
2.55.0