Skip to content

crypto: zstd - avoid initializing the workspace twice

Usama Arif linux-crypto lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto: zstd - Avoid redundant cstream initializationcrypto/zstd.c+14 -61 reply
2/2crypto: zstd - Avoid redundant dstream initializationcrypto/zstd.c+14 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] crypto: zstd - avoid initializing the workspace twice

Both zstd_compress() and zstd_decompress() set up the shared per-CPU workspace as a C/DStream before walking the request, and then, when the first source and destination fragments each span the whole request, hand off to zstd_compress_one()/zstd_decompress_one(), which immediately overwrite that same ctx->wksp with a CCtx/DCtx. The stream setup is discarded without a byte having been processed.

That one-shot path is not a corner case: zswap always takes it when storing, and takes it for a load whenever the stored object lies within a single zsmalloc page.

These two patches defer the stream initialization to the first walk iteration that actually streams, guarded by a flag because that iteration can be reached more than once.

A 4 KiB crypto_acomp benchmark [1], twelve runs of nine 30,000-operation rounds. Bare metal is an Intel Xeon Platinum 8321HC, turbo off, performance governor, pinned to one core; the VM is a one-vCPU KVM guest on a faster host.

baseline patched delta
bare metal

    compress      52,283 ns   51,038 ns   1,245 ns   2.4%
    decompress     2,317 ns    1,998 ns     319 ns  13.8%
  one-vCPU KVM
    compress      16,675 ns   15,050 ns   1,625 ns   9.8%
    decompress     3,516 ns    2,265 ns   1,251 ns  35.6%

The guest numbers are larger because the two CPUID instructions in ZSTD_cpuid() become unconditional VM exits there.

[1] https://gist.github.com/uarif1/5cf02f0e22c23f0d1b3d84348f12914c

Usama Arif (2):
crypto: zstd - Avoid redundant cstream initialization
crypto: zstd - Avoid redundant dstream initialization

 crypto/zstd.c | 40 ++++++++++++++++++++++++++++------------
 1 file changed, 28 insertions(+), 12 deletions(-)

base-commit: 4b18edbd8e70f7e6860d56370f13244896d0f95c

Signature · 1 line
2.53.0-Meta