Skip to content

media: rockchip: rkisp2: Add driver for ISP on Rk3588

Paul Elder linux-arm-kernel linux-devicetree linux-media linux-rockchip lkml 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20260826-rkisp2-cd295f7eae4a

Versions newest first · linked by author and title

  1. v3 Latest5 patches 6 repliesIn review
  2. v25 patches 6 repliesSuperseded
  3. v1 RFC5 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- add explicit padding to uapi structs
- reorder patches so that dt goes last
- move uapi header to a nicer location

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5media: rockchip: rkisp2: Add rkisp2 driverMAINTAINERS drivers/media/platform/rockchip/Kconfig drivers/media/platform/rockchip/Makefile +14 more+12049 -01 reply
2/5media: rkisp2: Add parameters output video nodeDocumentation/userspace-api/media/v4l/meta-formats.rst Documentation/userspace-api/media/v4l/metafmt-rkisp2.rst drivers/media/platform/rockchip/rkisp2/Makefile +9 more+1934 -21 reply
3/5media: rkisp2: Add statistics capture video nodeDocumentation/userspace-api/media/v4l/metafmt-rkisp2.rst drivers/media/platform/rockchip/rkisp2/Makefile drivers/media/platform/rockchip/rkisp2/rkisp2-common.h +10 more+1196 -61 reply
4/5dt-bindings: media: Add rockchip rkisp2Documentation/devicetree/bindings/media/rockchip-isp2.yaml+125 -01 reply
5/5arm64: dts: rockchip: add ISP nodes to rk3588arch/arm64/boot/dts/rockchip/rk3588-base.dtsi+57 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] media: rockchip: rkisp2: Add driver for ISP on Rk3588

Hello everyone!

This patch series adds a new rkisp2 driver that aims to support all Rockchip 2.x and 3.x series ISPs. Here we add support for the version on the RK3588, which as far as I'm aware is a 3.0.

Patches 1 and 2 add dt bindings and dt nodes; patches 3~5 add the actual driver.

Notable changes from the RFC version:
- fixed a couple potential page fault storms
- use extensible stats (previously only params were extensible)
- no more subdev pad crops; all cropping has been moved to parameter buffers so that they can be configured synchronously
- the DMA RX sink pads and the main/self path source pads on the ISP subdev have been split into individual pads
- an unused sink pad has been allocated on the ISP subdev for future inline mode support (to prevent uapi from changing)

Changes in v3:
- add explicit padding to uapi structs
- reorder patches so that dt goes last
- move uapi header to a nicer location

This series is based on the latest version (v7.2-rc1) (at the time of posting) of media-commiters/next [0], with some patches on top for testing on the Orange Pi CM5 Base with an imx708. I have a branch [1] that integrates this series on top of said patches and media-committers/next.

Corresponding libcamera patches+branch will be coming soon (within minutes), but since I cannot send and link these simultanously, you will have to search the libcamera mailing list :) I'll be sending a v3 to match the driver v3.

[0] https://gitlab.freedesktop.org/linux-media/media-committers/-/tree/4900cad020c0580dfb1be27776ff10a4ef110cfa
[1] https://git.ideasonboard.com/epaul/linux/src/branch/epaul/v7.2-rc1/rk3588/rkisp2/upstream-v3

To: Mauro Carvalho Chehab <[email protected]>
To: Heiko Stuebner <[email protected]>
To: Dafna Hirschfeld <[email protected]>
To: Laurent Pinchart <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: [email protected]
To: [email protected]
To: [email protected]
To: [email protected]
To: [email protected]
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
Paul Elder (3):
media: rkisp2: Add parameters output video node
media: rkisp2: Add statistics capture video node
dt-bindings: media: Add rockchip rkisp2

Xu Hongfei (2):
media: rockchip: rkisp2: Add rkisp2 driver
arm64: dts: rockchip: add ISP nodes to rk3588

 .../devicetree/bindings/media/rockchip-isp2.yaml   |  125 +
 .../userspace-api/media/v4l/meta-formats.rst       |    1 +
 .../userspace-api/media/v4l/metafmt-rkisp2.rst     |  112 +
 MAINTAINERS                                        |   10 +
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      |   57 +
 drivers/media/platform/rockchip/Kconfig            |    1 +
 drivers/media/platform/rockchip/Makefile           |    1 +
 drivers/media/platform/rockchip/rkisp2/Kconfig     |   19 +
 drivers/media/platform/rockchip/rkisp2/Makefile    |   14 +
 .../platform/rockchip/rkisp2/rkisp2-capture.c      | 1540 +++++++++
 .../media/platform/rockchip/rkisp2/rkisp2-common.c |  180 +
 .../media/platform/rockchip/rkisp2/rkisp2-common.h |  620 ++++
 .../media/platform/rockchip/rkisp2/rkisp2-debug.c  |  234 ++
 .../media/platform/rockchip/rkisp2/rkisp2-dev.c    |  372 +++
 .../media/platform/rockchip/rkisp2/rkisp2-dmarx.c  |  706 ++++
 .../media/platform/rockchip/rkisp2/rkisp2-isp.c    |  839 +++++
 .../media/platform/rockchip/rkisp2/rkisp2-params.c | 1167 +++++++
 .../platform/rockchip/rkisp2/rkisp2-regs-v2x.h     | 2625 +++++++++++++++
 .../platform/rockchip/rkisp2/rkisp2-regs-v3x.h     | 3428 ++++++++++++++++++++
 .../media/platform/rockchip/rkisp2/rkisp2-regs.h   | 1736 ++++++++++
 .../platform/rockchip/rkisp2/rkisp2-resizer.c      |  407 +++
 .../media/platform/rockchip/rkisp2/rkisp2-stats.c  |  509 +++
 drivers/media/v4l2-core/v4l2-ioctl.c               |    2 +
 include/uapi/linux/media/rockchip/rkisp2-config.h  |  643 ++++
 include/uapi/linux/rkisp1-config.h                 |    1 +
 include/uapi/linux/videodev2.h                     |    4 +
 26 files changed, 15353 insertions(+)

---
base-commit: 7517ffce3b70c999f6038fc87d4811004d994d25
change-id: 20260826-rkisp2-cd295f7eae4a

Best regards,

Signature · 1 line
Paul Elder <[email protected]>