zstd: probe the CPU for BMI2 support once, not per context
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | zstd: use ZSTD_cpuSupportsBmi2() in ZSTD_initStaticCCtx()lib/ | +1 | 0 replies | |
| 2/3 | zstd: skip the BMI2 probe when dynamic BMI2 dispatch is disabledlib/ | +5 | 0 replies | |
| 3/3 | zstd: probe the CPU for BMI2 support only oncelib/ | +15 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] zstd: probe the CPU for BMI2 support once, not per context
zstd picks between BMI2 and generic code paths at runtime, and issues CPUID to decide every time a compression or decompression context is set up. The answer cannot change while the kernel is running.
It is not a cold path: squashfs calls zstd_init_dstream() for every block it decompresses, and erofs, btrfs, f2fs and crypto/zstd all initialise a context per operation. Each probe is two serializing CPUID instructions on x86.
Patch 1 routes ZSTD_initStaticCCtx() through ZSTD_cpuSupportsBmi2() instead of open-coding the probe, which also fixes it testing for BMI2 without BMI1 - the bodies it selects are tagged TARGET_ATTRIBUTE("lzcnt,bmi,bmi2"), so both are needed. No CPU in the field implements BMI2 without BMI1, so this is latent. Patch 2 skips the probe when DYNAMIC_BMI2 is 0, where every consumer ignores the flag anyway. Patch 3 caches the result.
A 4 KiB crypto_acomp benchmark [1] in a one-vCPU KVM guest, twelve boots of nine 30,000-operation rounds, median per-round mean over 108 rounds:
compress decompress
unpatched 16,756 ns 3,455 ns
patched 13,646 ns 1,002 ns
-3,110 ns -2,452 ns
(18.6%) (71.0%)The main reason is because CPUID is an unconditional VM exit.
[1] https://gist.github.com/uarif1/5cf02f0e22c23f0d1b3d84348f12914c
Usama Arif (3):
zstd: use ZSTD_cpuSupportsBmi2() in ZSTD_initStaticCCtx()
zstd: skip the BMI2 probe when dynamic BMI2 dispatch is disabled
zstd: probe the CPU for BMI2 support only once
lib/zstd/common/zstd_internal.h | 22 ++++++++++++++++++++-- lib/zstd/compress/zstd_compress.c | 2 +- 2 files changed, 21 insertions(+), 3 deletions(-)
base-commit: 4b18edbd8e70f7e6860d56370f13244896d0f95c
Signature · 1 line
2.53.0-Meta