ALSA/ASoC: Intel: avs: HDAudio bus and general fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest10 patches 3 repliesIn review
- v310 patches 7 repliesSuperseded
- v211 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 10 patches | 4 replies | Superseded |
Changes in v3 from the cover letter
- dropped the patch introduced in v2 as an equivalent change has just been merged [1]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | ALSA: hda: ext: Clean up links if their initialization failssound/ | +3 | 1 reply | |
| 2/10 | ALSA: hda: ext: Clean up streams if their initialization failssound/ | +3 | 1 reply | |
| 3/10 | ASoC: Intel: avs: Clean up the bus when its initialization failssound/ | +17 | 0 replies | |
| 4/10 | ASoC: Intel: avs: Clean up the bus when fetching ML caps failssound/ | +9 | 0 replies | |
| 5/10 | ASoC: Intel: avs: Clean up streams if their initialization failssound/ | +15 | 0 replies | |
| 6/10 | ASoC: Intel: avs: Do not ignore -ENOENT when loading a topologysound/ sound/ sound/ | +22 | 0 replies | |
| 7/10 | ASoC: Intel: avs: Cancel d0ix_work asynchrounously during recoverysound/ | +3 | 0 replies | |
| 8/10 | ASoC: Intel: avs: Fix unbalanced module reference countsound/ | +9 | 0 replies | |
| 9/10 | ASoC: Intel: avs: Refactor and fix init_config accesssound/ sound/ sound/ | +32 | 0 replies | |
| 10/10 | ASoC: Intel: avs: hda: Constrain MSBs on startupsound/ | +17 | 0 replies |
Reviews trailers per patch
2 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Takashi Iwai |
|---|---|
| 1/10 | A-b |
| 2/10 | A-b |
| 3/10 | |
| 4/10 | |
| 5/10 | |
| 6/10 | |
| 7/10 | |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/10] ALSA/ASoC: Intel: avs: HDAudio bus and general fixes
The first half of the patchset concentrates on the driver initialization procedure - a number of steps do not clean up after themselves when they fail. This is for both, HDAudio bus (ext) and the DSP part (avs) and targets following procedures:
- stream initialization
- link initialization
- bus initialization
The next five are loosely related fixes. First, split topology-loading error handling from request-firmware one. Currently -ENOENT coming from topology-loading, which is a real error, is ignored.
Second, with deeper test coverage around corrupted firmware/DSP exception handling, new issues are unearthed. Switch to async d0ix_work cancellation to avoid deadlock when D0IX has been scheduled just before the recovery work.
The 09/10 patch, init_config change fixes possible out-of-bounds bug. The fix is larger than what one could expect as instead of patching with if-statements I've decided to refactor the parsing of init_configs. The scenario that causes the problem no longer exists.
Note: the solution does not impose any changes on the existing topology files (userspace).
The remaining two, IMHO are self-explanatory.
Chamges in v4:
- replaced error paths for patches 1/10 and 2/10 with snd_hdac_ext_link_free_all() and snd_hdac_ext_stream_free_all() respectively, as suggested by Takashi
Changes in v3:
- dropped the patch introduced in v2 as an equivalent change has just been merged [1]
Changes in v2:
- added patch "ALSA: hda: Clean up pages when stream buffers allocation fails" to address Mark's review for "ASoC: Intel: avs: Clean up the bus when its initialization fails" and clean up pages before collapsing the bus initialization
- removed unused 'acomp' variable as pointed out by Mark
[1]: https://lore.kernel.org/all/[email protected]/
Cezary Rojewski (10):
ALSA: hda: ext: Clean up links if their initialization fails
ALSA: hda: ext: Clean up streams if their initialization fails
ASoC: Intel: avs: Clean up the bus when its initialization fails
ASoC: Intel: avs: Clean up the bus when fetching ML caps fails
ASoC: Intel: avs: Clean up streams if their initialization fails
ASoC: Intel: avs: Do not ignore -ENOENT when loading a topology
ASoC: Intel: avs: Cancel d0ix_work asynchrounously during recovery
ASoC: Intel: avs: Fix unbalanced module reference count
ASoC: Intel: avs: Refactor and fix init_config access
ASoC: Intel: avs: hda: Constrain MSBs on startup
sound/hda/core/ext/controller.c | 4 +- sound/hda/core/ext/stream.c | 5 ++- sound/soc/intel/avs/boards/hdaudio.c | 17 ++++++++ sound/soc/intel/avs/core.c | 59 +++++++++++++++++++--------- sound/soc/intel/avs/debugfs.c | 12 ++++-- sound/soc/intel/avs/ipc.c | 6 +-- sound/soc/intel/avs/path.c | 11 ++---- sound/soc/intel/avs/pcm.c | 34 +++++++++------- sound/soc/intel/avs/topology.c | 49 +++++++++++++---------- sound/soc/intel/avs/topology.h | 5 ++- 10 files changed, 130 insertions(+), 72 deletions(-)
Signature · 1 line
2.34.1