io_uring passthru: set result on blk-mq request completion
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 1 replyApplied
- v22 patches 5 repliesSuperseded
- v12 patches 4 repliesSuperseded
Changes in v3 from the cover letter
- Inline io_uring_cmd_set_res*() (Ming, Jens)
- Document that io_uring_cmd_set_res*() must be called before __io_uring_cmd_done() (Joanne)
- Add Reviewed-by tag (Joanne)
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | io_uring: move req_set_*() to public headerinclude/ io_uring/ | +32 | 0 replies | |
| 2/3 | io_uring/cmd: split io_uring_cmd_set_res() from io_uring_cmd_done()include/ io_uring/ | +29 | 0 replies | |
| 3/3 | nvme/ioctl: call io_uring_cmd_set_res32() in ->end_io()drivers/ | +9 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Joanne Koong |
|---|---|
| 1/3 | |
| 2/3 | R-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] io_uring passthru: set result on blk-mq request completion
io_uring NVMe passthru currently receives the NVMe status and result in the blk-mq request completion callback nvme_uring_cmd_end_io() but doesn't post the io_uring CQE until the io_uring task work callback nvme_uring_task_cb(). The status and result must be plumbed through struct nvme_uring_cmd_pdu, taking up 16 bytes of the 32 available.
Store the status and result on the io_uring request in nvme_uring_cmd_end_io() instead of nvme_uring_task_cb() so it doesn't need to be passed through struct nvme_uring_cmd_pdu.
v3:
- Inline io_uring_cmd_set_res*() (Ming, Jens)
- Document that io_uring_cmd_set_res*() must be called before __io_uring_cmd_done() (Joanne)
- Add Reviewed-by tag (Joanne)
v2: https://lore.kernel.org/io-uring/[email protected]/
- Keep io_uring_cmd_done{,32}() wrappers to reduce changes in uring_cmd implementations (Joanne)
v1: https://lore.kernel.org/io-uring/[email protected]/
Caleb Sander Mateos (3):
io_uring: move req_set_*() to public header io_uring/cmd: split io_uring_cmd_set_res() from io_uring_cmd_done() nvme/ioctl: call io_uring_cmd_set_res32() in ->end_io()
drivers/nvme/host/ioctl.c | 19 +++++++++---------- include/linux/io_uring.h | 32 ++++++++++++++++++++++++++++++++ include/linux/io_uring/cmd.h | 34 ++++++++++++++++++++++++++++------ io_uring/io_uring.h | 31 ------------------------------- io_uring/uring_cmd.c | 19 +------------------ 5 files changed, 70 insertions(+), 65 deletions(-)
Signature · 1 line
2.55.0