Skip to content

platform/x86: asus-armoury: fix notifications for grouped attributes

Ahmed Yaseen lkml platform-driver-x86 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86: asus-armoury: fix sysfs_notify() of grouped attributesdrivers/platform/x86/asus-armoury.c drivers/platform/x86/asus-armoury.h+17 -140 replies
2/2platform/x86: asus-armoury: fix pending_reboot for grouped attributesdrivers/platform/x86/asus-armoury.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] platform/x86: asus-armoury: fix notifications for grouped attributes

Both fixes are the same mistake: the code identifies an attribute by attr->attr.name, but callers always pass a current_value attribute, and that name is always "current_value". sysfs_notify() therefore resolves nothing, and asus_bios_requires_reboot() never matches.

Patch 1 threads the group name down to the notify calls; patch 2 uses it for the reboot check, so it needs patch 1.

Ahmed Yaseen (2):
platform/x86: asus-armoury: fix sysfs_notify() of grouped attributes platform/x86: asus-armoury: fix pending_reboot for grouped attributes

 drivers/platform/x86/asus-armoury.c | 23 ++++++++++++-----------
 drivers/platform/x86/asus-armoury.h | 16 +++++++++-------
 2 files changed, 21 insertions(+), 18 deletions(-)

base-commit: e6664f2b33db9b6811eb4cec109f06cb2b4f458d

Signature · 1 line
2.55.0