Skip to content

drm/amdgpu/sdma: Improve existing SDMA queue resets

Timur Kristóf amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/amdgpu/sdma: Clear SDMA rings after reset before starting themdrivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c+12 -00 replies
2/5drm/amdgpu/sdma: Remove unimplemented soft_reset() for SDMA and SI DMAdrivers/gpu/drm/amd/amdgpu/sdma_v4_0.c drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c +1 more+0 -311 reply
3/5drm/amdgpu/sdma: Move SDMA v5.x queue reset to common codedrivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c +1 more+43 -486 replies
4/5drm/amdgpu/sdma: Use common SDMA legacy queue reset on SDMA v4.4.2drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c+2 -163 replies
5/5drm/amdgpu/sdma: In legacy queue reset function, check if KFD is initializeddrivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c+7 -22 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchLijo Lazar
1/5
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] drm/amdgpu/sdma: Improve existing SDMA queue resets

Improve SDMA queue reset for SDMA v4.4.2, v5.0, v5.2 and also moves some functionality from backend-specific code to common code in the amdgpu_sdma.c file.

This prepares for implementing SDMA queue resets on more generations, as the same logic can be shared with all SDMA HW generations that don't use the MES. The actual queue reset implementations for various older SDMA versions will come in subsequent patch series after this one is accepted.

Timur Kristóf (5):
drm/amdgpu/sdma: Clear SDMA rings after reset before starting them drm/amdgpu/sdma: Remove unimplemented soft_reset() for SDMA and SI DMA drm/amdgpu/sdma: Move SDMA v5.x queue reset to common code drm/amdgpu/sdma: Use common SDMA legacy queue reset on SDMA v4.4.2 drm/amdgpu/sdma: In legacy queue reset function, check if KFD is
initialized

 drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 54 ++++++++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h |  4 ++
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c   |  8 ----
 drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 26 +-----------
 drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c   | 33 +--------------
 drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c   | 25 +----------
 drivers/gpu/drm/amd/amdgpu/si_dma.c      |  7 ---
 7 files changed, 62 insertions(+), 95 deletions(-)
Signature · 1 line
2.55.0