Skip to content

VRAM health check + CCS fix

Matthew Auld intel-xe sashiko-reviews 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 4 repliesIn review
  2. v25 patches 1 replySuperseded
  3. v15 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- Fix the panic path in the VRAM CPU patch (Sashiko).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/xe/migrate: support 4K PTEs for identity mapdrivers/gpu/drm/xe/xe_migrate.c+37 -200 replies
2/5drm/xe/vram: report FLAT_CCS base misalignmentdrivers/gpu/drm/xe/xe_vram.c+3 -01 reply
3/5drm/xe/vram: revamp CPU VRAM mappingdrivers/gpu/drm/xe/display/xe_panic.c drivers/gpu/drm/xe/xe_vram.c+11 -62 replies
4/5drm/xe: add force option for global invalidationdrivers/gpu/drm/xe/display/xe_dsb_buffer.c drivers/gpu/drm/xe/display/xe_fb_pin.c drivers/gpu/drm/xe/xe_device.c +1 more+6 -60 replies
5/5drm/xe/vram: add early VRAM health checkdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_migrate.h +3 more+333 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMatthew Brost
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] VRAM health check + CCS fix

Add a basic VRAM health check routine, which does some basic sanity checking on the last VRAM page. This could be extended in the future. This seems to reproduce the same CCS issue as Linus, on my b570.

This also picks up the fix from Linus. I went with leaving it as-is, but that means we need to fixup the identity mapping to support 4K pages for the tail part of usable VRAM.

It doesn't look like anything in our CI actually has the CCS alignment issue present, so merging the fix from Linus without the identity map changes likely shouldn't trigger any asserts, if that does end up coming in via another tree, AFAICT.

v2:
- Give more details around what the VRAM health check actually does and how it catches the CCS bug (Matt B).
- Tweak the CCS base + alignment print (Matt B).
- Drop the fix from Linus; this is now already in drm-tip.
- Add some hardening for VRAM CPU mapping also.
v3:
- Fix the panic path in the VRAM CPU patch (Sashiko).

Signature · 1 line
2.55.0

Read the cover letter in its thread