Skip to content

RFC mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms

SJ Park damon linux-kselftest linux-mm lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mm/damon/tests/core-kunit: test committing psi goal to psi goalmm/damon/tests/core-kunit.h+7 -00 replies
2/4mm/damon/core: handle uninitialized damos_quota_goal->last_psi_totalmm/damon/core.c mm/damon/tests/core-kunit.h+14 -80 replies
3/4mm/damon/core: copy nid for eligible_mem_bp damos quota goal commitmm/damon/core.c+3 -00 replies
4/4mm/damon/sysfs: set next refresh jiffies per sysfs contextmm/damon/sysfs.c+5 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH v1.3 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms

DAMOS quota goals commit unit test is mistakenly not testing a test case that was designed to test. DAMOS quota goals and DAMON sysfs refresh_ms file have bugs that can produce non critical but still unexpected behaviors. Fix the bugs.

Patch 1 fixes the DAMOS quota goals commit unit test to cover a mistakenly uncovered case. Patches 2 and 3 fix the bugs in DAMOS PSI goal initialization and eligible_mem_bp online commit, respectively. Patch 4 fixes the bug in DAMON sysfs refresh_ms file handling.

Changes from RFC v1.2
- RFC v1.2: https://lore.kernel.org/[email protected]
- Fix last_psi_total underflow.
Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/[email protected]
- Fix quota goals commit unit test that was mistakenly missing a test case.
- Initialize last_psi_total as uninitialized at the beginning.
- Correct kunit test for changed last_psi_total initialization behavior. Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
(Mistakenly missed RFC tag)
- Fix build error.
- Add eligible_mem_bp nid commit fix.

SJ Park (4):
mm/damon/tests/core-kunit: test committing psi goal to psi goal mm/damon/core: handle uninitialized damos_quota_goal->last_psi_total mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit mm/damon/sysfs: set next refresh jiffies per sysfs context

 mm/damon/core.c             | 16 ++++++++++++++--
 mm/damon/sysfs.c            | 11 +++++------
 mm/damon/tests/core-kunit.h | 16 ++++++++++------
 3 files changed, 29 insertions(+), 14 deletions(-)

base-commit: f508ed0a3bc67ac2a17ba4eaa7f219a95f6b3954

Signature · 1 line
2.47.3