Skip to content

media: ak7375: Add AK7377 support

Jan-Michael Brummer linux-devicetree linux-media lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] media: ak7375: Add AK7377 support

The AK7377 drives the focus actuator of the main camera on the Fairphone 5, and is register compatible with the AK7375 already supported by this
driver: a 12 bit position in registers 0x00/0x01 shifted left by four, and standby control in 0x02. Patches 1 and 2 add the binding and the compatible.

Patch 3 is a fix that is independent of the above and applies to every user of this driver. probe() calls pm_runtime_set_active() while the regulators are still off, so the first runtime transition is a suspend against an unpowered chip; it fails its I2C writes and then disables regulators that were never enabled. On the Fairphone 5 that showed up as an -ENXIO from the first resume, after which focus control stayed dead for the whole session even though the actuator answered fine on the bus, and as a WARN from regulator_bulk_free() on unbind.

I can send patch 3 on its own if that is easier to route - it does not depend on the other two.

Testing: the AK7377 on a Fairphone 5, driving the lens across its range and checking that the image comes into focus, with an out-of-tree IMX800 sensor driver. I have no AK7345 or AK7375 hardware, so patch 3 is untested on those; the change moves the first runtime resume from probe to the first focus request, and confirmation that this does not regress them would be welcome.

Jan-Michael Brummer (3):
media: dt-bindings: ak7375: Add AK7377
media: i2c: ak7375: Add support for the AK7377
media: i2c: ak7375: Do not mark the VCM active before powering it

 .../bindings/media/i2c/asahi-kasei,ak7375.yaml |  1 +
 drivers/media/i2c/ak7375.c                     | 45 ++++++++++++++++---
 2 files changed, 41 insertions(+), 5 deletions(-)
Signature · 1 line
2.51.0