Skip to content

hwmon: it87: add IT8613E support

Jerome Tollet linux-doc linux-hwmon lkml 5 versions Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 3 repliesApplied
  2. v63 patches 2 repliesSuperseded
  3. v54 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC1 patch1 replySuperseded
v1 RFC1 patch0 repliesSuperseded

Changes in v7 from the cover letter

- Keep the existing three temperature limit and offset resources. Drop the unused per-chip limit and offset counts and the extended offset register table, so the driver no longer accesses unexposed resources.
- Limit the first patch to describing per-chip PWM temperature maps.
- Apply a deferred legacy temperature mapping when switching from manual to automatic PWM mode instead of clearing it.
- Leave the existing PWM polarity repair path unchanged. The first three PWM control register addresses are common to the register maps used by this series.
- Clarify that IT8613E has three known temperature inputs and six PWM temperature mapping sources.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/3hwmon: it87: describe per-chip PWM temperature mapsdrivers/hwmon/it87.c+38 -81 reply
2/3hwmon: it87: prepare for extended PWM temp mapsdrivers/hwmon/it87.c+166 -531 reply
3/3hwmon: it87: add IT8613E supportDocumentation/hwmon/it87.rst drivers/hwmon/it87.c+69 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH v7 0/3] hwmon: it87: add IT8613E support

This is a respin of Benoit Masson's v4 series, with his permission. It replaces my fan-input-only RFC with the broader hardware monitoring support requested in review.

The v4 series was dropped after a NULL pointer dereference was reported. The IT8613E device entry did not initialize reg_pwm, while the probe path unconditionally dereferences it. It also advertised six temperature offsets but the register table contained only three entries.

Changes in v7:
- Keep the existing three temperature limit and offset resources. Drop the unused per-chip limit and offset counts and the extended offset register table, so the driver no longer accesses unexposed resources.
- Limit the first patch to describing per-chip PWM temperature maps.
- Apply a deferred legacy temperature mapping when switching from manual to automatic PWM mode instead of clearing it.
- Leave the existing PWM polarity repair path unchanged. The first three PWM control register addresses are common to the register maps used by this series.
- Clarify that IT8613E has three known temperature inputs and six PWM temperature mapping sources.

Tested on an IT8613E at 0xa30, revision 12. Every intermediate commit and the complete series build as external modules with W=1. All three patches pass checkpatch --strict with no warnings or errors.

The module exposes fan2_input and PWM2, PWM4, and PWM5 on this system. The PWM2 temperature mapping was changed from 4 to 1 in manual mode. It remained 1 after a cache refresh and after switching back to automatic mode. The original mapping, duty, and automatic mode were then restored.

The PWM2 write path was tested by switching from automatic control to manual full duty (255). Fan2 increased from 2636 RPM to 6553 RPM. The original duty (65), automatic mode, and temperature mapping were restored.

An S3 suspend/resume cycle with an RTC wakeup completed successfully. The PWM configuration and sensor readings were preserved, with no it87 or hwmon warnings in the kernel log. The legacy mapping correction was compile-tested but could not be exercised on this newer controller.

benoit.masson (3):
hwmon: it87: describe per-chip PWM temperature maps
hwmon: it87: prepare for extended PWM temp maps
hwmon: it87: add IT8613E support

 Documentation/hwmon/it87.rst |   8 +
 drivers/hwmon/it87.c         | 308 +++++++++++++++++++++++++++++------
 2 files changed, 263 insertions(+), 53 deletions(-)

base-commit: 75f2c0b3690702c90863c2e138cb5520670845ea

Signature · 1 line
2.55.0