Skip to content

Improve coverage for keyctl() syscall

Andrea Cervesato ltp 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20260831-keyctl_coverage-345a4c4d7992

Versions newest first

  1. v2 Latest33 patches 31 repliesIn review
  2. v133 patches 1 replySuperseded

Changes in v2 from the cover letter

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/33lapi/keyctl.h: Add fallback definitions for extended opsinclude/lapi/keyctl.h m4/ltp-keyutils.m4+48 -13 replies
2/33keyctl10: Test KEYCTL_DESCRIBE format parsingruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl10.c +1 more+154 -01 reply
3/33keyctl11: Test KEYCTL_DESCRIBE with exact buffer sizeruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl11.c+64 -01 reply
4/33keyctl12: Test KEYCTL_DESCRIBE with too small bufferruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl12.c+64 -03 replies
5/33keyctl13: Test KEYCTL_DESCRIBE size queryruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl13.c+48 -00 replies
6/33keyctl14: Negative tests for KEYCTL_DESCRIBEruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl14.c+56 -01 reply
7/33keyctl15: Test KEYCTL_GET_SECURITY label retrievalruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl15.c+68 -04 replies
8/33keyctl16: Test KEYCTL_GET_SECURITY truncated copyruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl16.c+76 -01 reply
9/33keyctl17: Negative tests for KEYCTL_GET_SECURITYruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl17.c+57 -01 reply
10/33keyctl18: Test basic KEYCTL_MOVEruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl18.c+62 -01 reply
11/33keyctl19: Test KEYCTL_MOVE with same source and destinationruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl19.c+45 -01 reply
12/33keyctl20: Test KEYCTL_MOVE displacementruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl20.c+64 -01 reply
13/33keyctl21: Negative and boundary tests for KEYCTL_MOVEruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl21.c+113 -01 reply
14/33keyctl22: Test KEYCTL_RESTRICT_KEYRING reject-allruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl22.c+56 -01 reply
15/33keyctl23: Test KEYCTL_RESTRICT_KEYRING builtin_trustedruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl23.c+144 -02 replies
16/33keyctl24: Negative tests for KEYCTL_RESTRICT_KEYRINGruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl24.c+175 -01 reply
17/33keyctl25: Test KEYCTL_DH_COMPUTE shared secret computationruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl25.c +1 more+142 -01 reply
18/33keyctl26: Test KEYCTL_DH_COMPUTE size queryruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl26.c+55 -02 replies
19/33keyctl27: Test KEYCTL_DH_COMPUTE KDF key derivationruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl27.c +1 more+85 -01 reply
20/33keyctl28: Negative and boundary tests for KEYCTL_DH_COMPUTEruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl28.c+142 -01 reply
21/33lapi/keyctl.h: Add fallback definitions for public key opsinclude/lapi/keyctl.h+56 -00 replies
22/33keyctl29: Test KEYCTL_PKEY_QUERY on public keyruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl29.c +2 more+180 -01 reply
23/33keyctl30: Test KEYCTL_PKEY_QUERY on private keyruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl30.c +1 more+172 -01 reply
24/33keyctl31: Test KEYCTL_PKEY_ENCRYPT and KEYCTL_PKEY_DECRYPTruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl31.c+112 -00 replies
25/33keyctl32: Test KEYCTL_PKEY_SIGN and VERIFYruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl32.c+123 -00 replies
26/33keyctl33: Negative tests for KEYCTL_PKEY_*runtest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl33.c+249 -00 replies
27/33lapi/keyctl.h: Add capability fallback definesinclude/lapi/keyctl.h+49 -00 replies
28/33keyctl34: Test KEYCTL_CAPABILITIES flag retrievalruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl34.c+64 -01 reply
29/33keyctl35: Test KEYCTL_CAPABILITIES size queryruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl35.c+51 -00 replies
30/33keyctl36: Test KEYCTL_CAPABILITIES buffer sizingruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl36.c+90 -00 replies
31/33keyctl37: Negative tests for KEYCTL_CAPABILITIESruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl37.c+65 -00 replies
32/33keyctl38: Test KEYCTL_WATCH_KEY add and removeruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl38.c+93 -00 replies
33/33keyctl39: Negative tests for KEYCTL_WATCH_KEYruntest/syscalls testcases/kernel/syscalls/keyctl/.gitignore testcases/kernel/syscalls/keyctl/keyctl39.c+151 -00 replies

Reviews trailers per patch

3 of 33 patches have a Reviewed-by or Acked-by.

PatchCyril Hrubis
1/33
2/33
3/33
4/33
5/33
6/33R-b
7/33
8/33
9/33R-b
10/33
11/33R-b
12/33
13/33
14/33
15/33
16/33
17/33
18/33
19/33
20/33
21/33
22/33
23/33
24/33
25/33
26/33
27/33
28/33
29/33
30/33
31/33
32/33
33/33

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [LTP] [PATCH v2 00/33] Improve coverage for keyctl() syscall

Improve the keyctl() syscall coverage by adding more tests for the following features, which are not currently tested in LTP:

- KEYCTL_DESCRIBE
- KEYCTL_GET_SECURITY
- KEYCTL_MOVE
- KEYCTL_RESTRICT_KEYRING
- KEYCTL_DH_COMPUTE
- KEYCTL_PKEY_*
- KEYCTL_CAPABILITIES
- KEYCTL_WATCH_KEY

The testing suite has been assisted by GLM 5.3 for coverage analysis and Gemini Flash 3.7 for the tests skeleton.

Validation: https://openqa.opensuse.org/tests/6199954#

---
Changes in v2:
- fix build
- Link to v1: https://lore.kernel.org/[email protected]

To: Linux Test Project <[email protected]>

---
Andrea Cervesato (33):
lapi/keyctl.h: Add fallback definitions for extended ops
keyctl10: Test KEYCTL_DESCRIBE format parsing
keyctl11: Test KEYCTL_DESCRIBE with exact buffer size
keyctl12: Test KEYCTL_DESCRIBE with too small buffer
keyctl13: Test KEYCTL_DESCRIBE size query
keyctl14: Negative tests for KEYCTL_DESCRIBE
keyctl15: Test KEYCTL_GET_SECURITY label retrieval
keyctl16: Test KEYCTL_GET_SECURITY truncated copy
keyctl17: Negative tests for KEYCTL_GET_SECURITY
keyctl18: Test basic KEYCTL_MOVE
keyctl19: Test KEYCTL_MOVE with same source and destination
keyctl20: Test KEYCTL_MOVE displacement
keyctl21: Negative and boundary tests for KEYCTL_MOVE
keyctl22: Test KEYCTL_RESTRICT_KEYRING reject-all
keyctl23: Test KEYCTL_RESTRICT_KEYRING builtin_trusted
keyctl24: Negative tests for KEYCTL_RESTRICT_KEYRING
keyctl25: Test KEYCTL_DH_COMPUTE shared secret computation
keyctl26: Test KEYCTL_DH_COMPUTE size query
keyctl27: Test KEYCTL_DH_COMPUTE KDF key derivation
keyctl28: Negative and boundary tests for KEYCTL_DH_COMPUTE lapi/keyctl.h: Add fallback definitions for public key ops
keyctl29: Test KEYCTL_PKEY_QUERY on public key
keyctl30: Test KEYCTL_PKEY_QUERY on private key
keyctl31: Test KEYCTL_PKEY_ENCRYPT and KEYCTL_PKEY_DECRYPT
keyctl32: Test KEYCTL_PKEY_SIGN and VERIFY
keyctl33: Negative tests for KEYCTL_PKEY_* lapi/keyctl.h: Add capability fallback defines
keyctl34: Test KEYCTL_CAPABILITIES flag retrieval
keyctl35: Test KEYCTL_CAPABILITIES size query
keyctl36: Test KEYCTL_CAPABILITIES buffer sizing
keyctl37: Negative tests for KEYCTL_CAPABILITIES
keyctl38: Test KEYCTL_WATCH_KEY add and remove
keyctl39: Negative tests for KEYCTL_WATCH_KEY

 include/lapi/keyctl.h                              | 141 +++++++++++-
 m4/ltp-keyutils.m4                                 |  13 ++
 runtest/syscalls                                   |  30 +++
 testcases/kernel/syscalls/keyctl/.gitignore        |  30 +++
 testcases/kernel/syscalls/keyctl/keyctl10.c        |  99 +++++++++
 testcases/kernel/syscalls/keyctl/keyctl11.c        |  62 ++++++
 testcases/kernel/syscalls/keyctl/keyctl12.c        |  62 ++++++
 testcases/kernel/syscalls/keyctl/keyctl13.c        |  46 ++++
 testcases/kernel/syscalls/keyctl/keyctl14.c        |  54 +++++
 testcases/kernel/syscalls/keyctl/keyctl15.c        |  66 ++++++
 testcases/kernel/syscalls/keyctl/keyctl16.c        |  74 ++++++
 testcases/kernel/syscalls/keyctl/keyctl17.c        |  55 +++++
 testcases/kernel/syscalls/keyctl/keyctl18.c        |  60 +++++
 testcases/kernel/syscalls/keyctl/keyctl19.c        |  43 ++++
 testcases/kernel/syscalls/keyctl/keyctl20.c        |  62 ++++++
 testcases/kernel/syscalls/keyctl/keyctl21.c        | 111 +++++++++
 testcases/kernel/syscalls/keyctl/keyctl22.c        |  54 +++++
 testcases/kernel/syscalls/keyctl/keyctl23.c        | 142 ++++++++++++
 testcases/kernel/syscalls/keyctl/keyctl24.c        | 173 +++++++++++++++
 testcases/kernel/syscalls/keyctl/keyctl25.c        |  66 ++++++
 testcases/kernel/syscalls/keyctl/keyctl26.c        |  53 +++++
 testcases/kernel/syscalls/keyctl/keyctl27.c        |  78 +++++++
 testcases/kernel/syscalls/keyctl/keyctl28.c        | 140 ++++++++++++
 testcases/kernel/syscalls/keyctl/keyctl29.c        |  90 ++++++++
 testcases/kernel/syscalls/keyctl/keyctl30.c        |  86 +++++++
 testcases/kernel/syscalls/keyctl/keyctl31.c        | 110 +++++++++
 testcases/kernel/syscalls/keyctl/keyctl32.c        | 121 ++++++++++
 testcases/kernel/syscalls/keyctl/keyctl33.c        | 247 +++++++++++++++++++++
 testcases/kernel/syscalls/keyctl/keyctl34.c        |  62 ++++++
 testcases/kernel/syscalls/keyctl/keyctl35.c        |  49 ++++
 testcases/kernel/syscalls/keyctl/keyctl36.c        |  88 ++++++++
 testcases/kernel/syscalls/keyctl/keyctl37.c        |  63 ++++++
 testcases/kernel/syscalls/keyctl/keyctl38.c        |  91 ++++++++
 testcases/kernel/syscalls/keyctl/keyctl39.c        | 149 +++++++++++++
 testcases/kernel/syscalls/keyctl/keyctl_common.h   |  73 ++++++
 testcases/kernel/syscalls/keyctl/keyctl_dh_data.h  |  79 +++++++
 .../kernel/syscalls/keyctl/keyctl_pkey_data.h      | 152 +++++++++++++
 37 files changed, 3173 insertions(+), 1 deletion(-)

---
base-commit: 043bdc49af410f55ece6f61abcdaba7d9580f86a
change-id: 20260831-keyctl_coverage-345a4c4d7992

Best regards,

Signature · 5 lines
Andrea Cervesato <[email protected]>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp