Introduce xe_wedge
Status from this message: Applied to drm-xe-next. Thanks for the patches and reviews!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v14 Latest9 patches 1 replyApplied
- v139 patches 3 repliesSuperseded
- v129 patches 0 repliesSuperseded
Earlier versions · 10
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v11 | 9 patches | 0 replies | Superseded | |
| v10 | 9 patches | 0 replies | Superseded | |
| v9 | 7 patches | 0 replies | Superseded | |
| v8 | 7 patches | 3 replies | Superseded | |
| v7 | 7 patches | 0 replies | Superseded | |
| v6 | 7 patches | 4 replies | Superseded | |
| v5 | 5 patches | 5 replies | Superseded | |
| v4 | 5 patches | 3 replies | Superseded | |
| v3 | 5 patches | 9 replies | Superseded | |
| v2 | 5 patches | 4 replies | Superseded |
Patches in v14 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | drm/xe/gt: Use GT ordered workqueue for wedgingdrivers/ drivers/ drivers/ +2 more | +44 | 0 replies | |
| 2/9 | drm/xe: Drop xe_device_set_wedged_method()drivers/ drivers/ drivers/ +8 more | +23 | 0 replies | |
| 3/9 | drm/xe/hw_error: Guard csc_hw_error_work() with runtime PMdrivers/ | +2 | 0 replies | |
| 4/9 | drm/xe: Move xe_device_wedged_fini() registration to xe_device_probe_early()drivers/ | +6 | 0 replies | |
| 5/9 | drm/xe: Make xe_device_declare_wedged() IRQ safedrivers/ drivers/ | +25 | 0 replies | |
| 6/9 | drm/xe/pci_error: Flush GT wedge worker before bus resetdrivers/ | +3 | 0 replies | |
| 7/9 | drm/xe/amc: Guard xe_amc_work() with runtime PMdrivers/ | +7 | 0 replies | |
| 8/9 | drm/xe: Introduce xe_wedgeDocumentation/ drivers/ drivers/ +27 more | +405 | 0 replies | |
| 9/9 | drm/xe/ras: Move xe_ras_process_errors() to xe_rasdrivers/ drivers/ | +7 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Matthew Brost | Rodrigo Vivi | Riana Tauro |
|---|---|---|---|
| 1/9 | R-b | ||
| 2/9 | R-b | ||
| 3/9 | R-b | ||
| 4/9 | R-b | ||
| 5/9 | R-b | ||
| 6/9 | R-b | ||
| 7/9 | R-b | ||
| 8/9 | A-b | R-b | |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v14 0/9] Introduce xe_wedge
In the history of xe technical debt, this series takes one more step and consolidates all wedging implementation into a dedicated xe_wedge component.
While at it, this fixes a few pre-existing issues related to wedge handling. Detailed description in commit message.
v1: https://patchwork.freedesktop.org/series/172727/
v2: Split fixes into separate patches (Rodrigo, Michal)
Also move struct xe_wedge and wedged_mode debt to xe_wedge (Lukasz, Michal) Naming and aesthetic adjustments (Lukasz, Michal)
v3: Respect the component namespace (Rodrigo)
Avoid chaining header includes (Rodrigo) Squash debugfs changes with xe_wedge patch (Lukasz)
v4: Introduce for_each_initialized_gt() (Michal)
Include xe_sriov.h (Rodrigo)
v5: Flush GT wedge worker to avoid races (Sashiko)
Drop IRQ safe wedging for its flawed design
v6: Move wedge worker initialization to xe_gt_init_early() (Rodrigo)
Don't flush GT wedge worker to avoid deadlock (Sashiko) Include IRQ safe wedging with redesign
v7: Guard GT wedge worker with runtime PM (Rodrigo)
Retain xe_pm_runtime_get_noresume() in IRQ context (Rodrigo)
v8: Rebase
v9: Drop runtime PM guard from GT wedge worker (Matthew Brost)
v10: Guard wedge callers with runtime PM (Sashiko)
v11: Use traditional xe_pm_runtime_get/put() with goto (Sashiko)
v12: Teardown GT wedge worker alongside GT reset worker (Sashiko)
v13: Avoid deadlock with GuC CT waiters (Sashiko)
v14: Rebase
Raag Jadav (9):
drm/xe/gt: Use GT ordered workqueue for wedging drm/xe: Drop xe_device_set_wedged_method() drm/xe/hw_error: Guard csc_hw_error_work() with runtime PM drm/xe: Move xe_device_wedged_fini() registration to
xe_device_probe_early()
drm/xe: Make xe_device_declare_wedged() IRQ safe drm/xe/pci_error: Flush GT wedge worker before bus reset drm/xe/amc: Guard xe_amc_work() with runtime PM drm/xe: Introduce xe_wedge
drm/xe/ras: Move xe_ras_process_errors() to xe_ras
Documentation/gpu/xe/xe_device.rst | 2 +- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/tests/xe_kunit_helpers.c | 3 +- drivers/gpu/drm/xe/xe_amc.c | 11 +- drivers/gpu/drm/xe/xe_bo.c | 3 +- drivers/gpu/drm/xe/xe_debugfs.c | 66 +---- drivers/gpu/drm/xe/xe_device.c | 190 +------------- drivers/gpu/drm/xe/xe_device.h | 14 +- drivers/gpu/drm/xe/xe_device_types.h | 28 +-- drivers/gpu/drm/xe/xe_gsc.c | 4 +- drivers/gpu/drm/xe/xe_gt.c | 48 +++- drivers/gpu/drm/xe/xe_gt.h | 2 +- drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 3 +- drivers/gpu/drm/xe/xe_gt_types.h | 9 + drivers/gpu/drm/xe/xe_guc.c | 5 +- drivers/gpu/drm/xe/xe_guc.h | 2 +- drivers/gpu/drm/xe/xe_guc_ct.c | 7 +- drivers/gpu/drm/xe/xe_guc_pc.c | 11 +- drivers/gpu/drm/xe/xe_guc_rc.c | 5 +- drivers/gpu/drm/xe/xe_guc_submit.c | 14 +- drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 3 +- drivers/gpu/drm/xe/xe_hw_error.c | 2 + drivers/gpu/drm/xe/xe_mert.c | 5 +- drivers/gpu/drm/xe/xe_pci_error.c | 13 +- drivers/gpu/drm/xe/xe_ras.c | 11 +- drivers/gpu/drm/xe/xe_sriov_pf.c | 3 +- drivers/gpu/drm/xe/xe_survivability_mode.c | 4 +- drivers/gpu/drm/xe/xe_uc.c | 6 +- drivers/gpu/drm/xe/xe_uc.h | 2 +- drivers/gpu/drm/xe/xe_wedge.c | 262 ++++++++++++++++++++ drivers/gpu/drm/xe/xe_wedge.h | 24 ++ drivers/gpu/drm/xe/xe_wedge_types.h | 44 ++++ 32 files changed, 468 insertions(+), 339 deletions(-) create mode 100644 drivers/gpu/drm/xe/xe_wedge.c create mode 100644 drivers/gpu/drm/xe/xe_wedge.h create mode 100644 drivers/gpu/drm/xe/xe_wedge_types.h
Signature · 1 line
2.43.0