Skip to content

Introduce xe_wedge

Raag Jadav intel-xe 13 versions – Applied

Status from this message: Applied to drm-xe-next. Thanks for the patches and reviews!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v14 Latest9 patches 1 replyApplied
  2. v139 patches 3 repliesSuperseded
  3. v129 patches 0 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v119 patches0 repliesSuperseded
v109 patches0 repliesSuperseded
v97 patches0 repliesSuperseded
v87 patches3 repliesSuperseded
v77 patches0 repliesSuperseded
v67 patches4 repliesSuperseded
v55 patches5 repliesSuperseded
v45 patches3 repliesSuperseded
v35 patches9 repliesSuperseded
v25 patches4 repliesSuperseded

Patches in v14 Applied

#Subject and filesSizeRepliesApplied
1/9drm/xe/gt: Use GT ordered workqueue for wedgingdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h drivers/gpu/drm/xe/xe_gt.c +2 more+44 -110 replies
2/9drm/xe: Drop xe_device_set_wedged_method()drivers/gpu/drm/xe/xe_amc.c drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h +8 more+23 -370 replies
3/9drm/xe/hw_error: Guard csc_hw_error_work() with runtime PMdrivers/gpu/drm/xe/xe_hw_error.c+2 -00 replies
4/9drm/xe: Move xe_device_wedged_fini() registration to xe_device_probe_early()drivers/gpu/drm/xe/xe_device.c+6 -40 replies
5/9drm/xe: Make xe_device_declare_wedged() IRQ safedrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device_types.h+25 -80 replies
6/9drm/xe/pci_error: Flush GT wedge worker before bus resetdrivers/gpu/drm/xe/xe_pci_error.c+3 -10 replies
7/9drm/xe/amc: Guard xe_amc_work() with runtime PMdrivers/gpu/drm/xe/xe_amc.c+7 -00 replies
8/9drm/xe: Introduce xe_wedgeDocumentation/gpu/xe/xe_device.rst drivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/tests/xe_kunit_helpers.c +27 more+405 -3250 replies
9/9drm/xe/ras: Move xe_ras_process_errors() to xe_rasdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_ras.c+7 -70 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchMatthew BrostRodrigo ViviRiana Tauro
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9A-b R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v14 thread

Cover letter [PATCH v14 0/9] Introduce xe_wedge

In the history of xe technical debt, this series takes one more step and consolidates all wedging implementation into a dedicated xe_wedge component.

While at it, this fixes a few pre-existing issues related to wedge handling. Detailed description in commit message.

v1: https://patchwork.freedesktop.org/series/172727/

v2: Split fixes into separate patches (Rodrigo, Michal)
Also move struct xe_wedge and wedged_mode debt to xe_wedge (Lukasz, Michal) Naming and aesthetic adjustments (Lukasz, Michal)

v3: Respect the component namespace (Rodrigo)
Avoid chaining header includes (Rodrigo) Squash debugfs changes with xe_wedge patch (Lukasz)

v4: Introduce for_each_initialized_gt() (Michal)
Include xe_sriov.h (Rodrigo)

v5: Flush GT wedge worker to avoid races (Sashiko)
Drop IRQ safe wedging for its flawed design

v6: Move wedge worker initialization to xe_gt_init_early() (Rodrigo)
Don't flush GT wedge worker to avoid deadlock (Sashiko) Include IRQ safe wedging with redesign

v7: Guard GT wedge worker with runtime PM (Rodrigo)
Retain xe_pm_runtime_get_noresume() in IRQ context (Rodrigo)

v8: Rebase

v9: Drop runtime PM guard from GT wedge worker (Matthew Brost)

v10: Guard wedge callers with runtime PM (Sashiko)

v11: Use traditional xe_pm_runtime_get/put() with goto (Sashiko)

v12: Teardown GT wedge worker alongside GT reset worker (Sashiko)

v13: Avoid deadlock with GuC CT waiters (Sashiko)

v14: Rebase

Raag Jadav (9):
drm/xe/gt: Use GT ordered workqueue for wedging drm/xe: Drop xe_device_set_wedged_method() drm/xe/hw_error: Guard csc_hw_error_work() with runtime PM drm/xe: Move xe_device_wedged_fini() registration to
xe_device_probe_early()
drm/xe: Make xe_device_declare_wedged() IRQ safe drm/xe/pci_error: Flush GT wedge worker before bus reset drm/xe/amc: Guard xe_amc_work() with runtime PM drm/xe: Introduce xe_wedge
drm/xe/ras: Move xe_ras_process_errors() to xe_ras

 Documentation/gpu/xe/xe_device.rst          |   2 +-
 drivers/gpu/drm/xe/Makefile                 |   1 +
 drivers/gpu/drm/xe/tests/xe_kunit_helpers.c |   3 +-
 drivers/gpu/drm/xe/xe_amc.c                 |  11 +-
 drivers/gpu/drm/xe/xe_bo.c                  |   3 +-
 drivers/gpu/drm/xe/xe_debugfs.c             |  66 +----
 drivers/gpu/drm/xe/xe_device.c              | 190 +-------------
 drivers/gpu/drm/xe/xe_device.h              |  14 +-
 drivers/gpu/drm/xe/xe_device_types.h        |  28 +--
 drivers/gpu/drm/xe/xe_gsc.c                 |   4 +-
 drivers/gpu/drm/xe/xe_gt.c                  |  48 +++-
 drivers/gpu/drm/xe/xe_gt.h                  |   2 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c         |   3 +-
 drivers/gpu/drm/xe/xe_gt_types.h            |   9 +
 drivers/gpu/drm/xe/xe_guc.c                 |   5 +-
 drivers/gpu/drm/xe/xe_guc.h                 |   2 +-
 drivers/gpu/drm/xe/xe_guc_ct.c              |   7 +-
 drivers/gpu/drm/xe/xe_guc_pc.c              |  11 +-
 drivers/gpu/drm/xe/xe_guc_rc.c              |   5 +-
 drivers/gpu/drm/xe/xe_guc_submit.c          |  14 +-
 drivers/gpu/drm/xe/xe_guc_tlb_inval.c       |   3 +-
 drivers/gpu/drm/xe/xe_hw_error.c            |   2 +
 drivers/gpu/drm/xe/xe_mert.c                |   5 +-
 drivers/gpu/drm/xe/xe_pci_error.c           |  13 +-
 drivers/gpu/drm/xe/xe_ras.c                 |  11 +-
 drivers/gpu/drm/xe/xe_sriov_pf.c            |   3 +-
 drivers/gpu/drm/xe/xe_survivability_mode.c  |   4 +-
 drivers/gpu/drm/xe/xe_uc.c                  |   6 +-
 drivers/gpu/drm/xe/xe_uc.h                  |   2 +-
 drivers/gpu/drm/xe/xe_wedge.c               | 262 ++++++++++++++++++++
 drivers/gpu/drm/xe/xe_wedge.h               |  24 ++
 drivers/gpu/drm/xe/xe_wedge_types.h         |  44 ++++
 32 files changed, 468 insertions(+), 339 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_wedge.c
 create mode 100644 drivers/gpu/drm/xe/xe_wedge.h
 create mode 100644 drivers/gpu/drm/xe/xe_wedge_types.h
Signature · 1 line
2.43.0