Skip to content

Add SoundWire detach helper

Charles Keepax linux-sound lkml mfd 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v2 posting 3/32 patches 2 repliesSuperseded
  3. v2 posting 2/32 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/32 patches7 repliesSuperseded
v12 patches2 repliesSuperseded

Changes in v3 from the cover letter

- Updated comment on cs42l43_soft_reset()

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2soundwire: Add a helper function to indicate a device will detachdrivers/soundwire/bus.h include/linux/soundwire/sdw.h+26 -60 replies
2/2mfd: cs42l43: Move to core detach helperdrivers/mfd/cs42l43-sdw.c drivers/mfd/cs42l43.c include/linux/mfd/cs42l43.h+4 -200 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartVinod Koul
1/2R-b A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Add SoundWire detach helper

Currently, if a SoundWire driver takes an action that causes the device to detach from the bus it needs to be careful. There will be a period of time until the detach is recognised by the core, if the driver immediately calls sdw_slave_wait_for_init() it is possible for that to complete before the detach has been recognised. Leaving the driver with a device that is potentially not ready for what follows.

To avoid this race add a new helper that drivers can use to inform the core the device will detach. This clears the enumeration completions ensuring that sdw_slave_wait_for_init() can't complete until the device re-attaches.

This is the third part of a longer series of moving these slave attach/deatach operations into the core:

https://lore.kernel.org/linux-sound/[email protected]/
https://lore.kernel.org/linux-sound/[email protected]/

Changes since v2:
- Updated comment on cs42l43_soft_reset()

Changes since v1:
- Correct kerneldoc

Charles Keepax (2):
soundwire: Add a helper function to indicate a device will detach
mfd: cs42l43: Move to core detach helper

 drivers/mfd/cs42l43-sdw.c     |  2 --
 drivers/mfd/cs42l43.c         | 21 ++++-----------------
 drivers/soundwire/bus.h       |  6 ------
 include/linux/mfd/cs42l43.h   |  1 -
 include/linux/soundwire/sdw.h | 26 ++++++++++++++++++++++++++
 5 files changed, 30 insertions(+), 26 deletions(-)
Signature · 1 line
2.47.3