Skip to content

Input: evdev/uinput errno alignment

Iván Ezequiel Rodriguez linux-input lkml 2 versions Applied

Status from this message: Applied, thank you.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesApplied
  2. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Dropped the ABS_MT_SLOT "minimum must be 0" validation from patch 2. It was a userspace regression: uinput_create_device() already calls input_mt_init_slots() for devices declaring ABS_MT_SLOT, and input_mt_init_slots() overwrites the axis with input_set_abs_params(dev, ABS_MT_SLOT, 0, num_slots - 1, 0, 0). A non-zero minimum is therefore accepted today and silently corrected, so rejecting it with -EINVAL would break existing callers.
- Patch 2 is now limited to the -ERANGE to -EINVAL change and its commit message was reworded accordingly.
- Patch 1 is unchanged.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2Input: evdev: propagate EVIOCSFF copy errors correctlydrivers/input/evdev.c+3 -21 reply
2/2Input: uinput: return -EINVAL for out-of-range UI_ABS_SETUP axis codedrivers/input/misc/uinput.c+1 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Input: evdev/uinput errno alignment

Two small fixes making evdev and uinput report the error codes their uapi documentation promises.

Changes since v1:
- Dropped the ABS_MT_SLOT "minimum must be 0" validation from patch 2. It was a userspace regression: uinput_create_device() already calls input_mt_init_slots() for devices declaring ABS_MT_SLOT, and input_mt_init_slots() overwrites the axis with input_set_abs_params(dev, ABS_MT_SLOT, 0, num_slots - 1, 0, 0). A non-zero minimum is therefore accepted today and silently corrected, so rejecting it with -EINVAL would break existing callers.
- Patch 2 is now limited to the -ERANGE to -EINVAL change and its commit message was reworded accordingly.
- Patch 1 is unchanged.

v1: https://lore.kernel.org/linux-input/[email protected]/

Iván Ezequiel Rodriguez (2):
Input: evdev: propagate EVIOCSFF copy errors correctly
Input: uinput: return -EINVAL for out-of-range UI_ABS_SETUP axis code

 drivers/input/evdev.c       | 5 +++--
 drivers/input/misc/uinput.c | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0