mm: make MAP_PRIVATE-/dev/zero mappings truly anonymous
Status from this message: [merged mm-stable] tools-testing-selftests-mm-add-map_private-dev-zero-merge-tests.patch removed from -mm tree
Get series with b4
b4 am [email protected] change-id 20260902-map-private-dev-zero-ba36d76a2fc8Versions newest first
- v3 Latest6 patches 2 repliesApplied 6/6
- v26 patches 6 repliesSuperseded
- v16 patches 12 repliesSuperseded
Changes in v3 from the cover letter
* Added tags (thanks David! :)
* Moved the reworked mmap_prepare vm_ops comment to 3/6 where it is introduced and fixed a typo in it, as per David.
Patches in v3 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mm: move drivers/char/mem.c to mm/char-mem.cMAINTAINERS drivers/ mm/ +2 more | +7 | 0 replies | Applied |
| 2/6 | mm: implement file_is_dev_zero() to uniquely identify /dev/zeromm/ mm/ tools/ +1 more | +32 | 0 replies | Applied |
| 3/6 | mm/vma: only permit MAP_PRIVATE /dev/zero to be mapped anonymousmm/ mm/ mm/ | +36 | 0 replies | Applied |
| 4/6 | mm/vma: make MAP_PRIVATE-mapped /dev/zero mappings truly anonymousinclude/ include/ mm/ +4 more | +23 | 0 replies | Applied |
| 5/6 | tools/testing/vma: add test to assert MAP_PRIVATE-/dev/zero is anontools/ | +37 | 0 replies | Applied |
| 6/6 | tools/testing/selftests/mm: add MAP_PRIVATE-/dev/zero merge teststools/ | +95 | 0 replies | Applied |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | David Hildenbrand (Arm) | Mike Rapoport (Microsoft) |
|---|---|---|
| 1/6 | A-b | A-b |
| 2/6 | A-b | |
| 3/6 | A-b | |
| 4/6 | A-b | |
| 5/6 | A-b | |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/6] mm: make MAP_PRIVATE-/dev/zero mappings truly anonymous
Historically anonymous memory was obtained in linux by MAP_PRIVATE-mapping /dev/zero.
The canonical way of doing these now is mmap() specifying MAP_PRIVATE | MAP_ANON, but we must continue to support the legacy means of obtaining these mappings.
As-is these mappings are an unusual edge-case - they satisfy vma_is_anonymous() but have non-NULL vma->vm_file, and their page offset is the offset into the /dev/zero file.
Commit 93c0c8dc87f6 ("mm/rmap: use anon pgoff to track MAP_PRIVATE file-backed anon folios") causes all other anonymous folios to be tracked by their anon index (vma->vm_start >> PAGE_SHIFT at the point of first fault), leaving MAP_PRIVATE-/dev/zero as the outlier.
This series remedies the situation by making MAP_PRIVATE-/dev/zero mappings truly anonymous with !vma->vm_file and correct anonymous page offset.
It starts by bringing the memory character driver into mm/ - this file implements /dev/zero, /dev/mem among other things and is already (as clearly indicated by its name) within the remit of memory management.
By doing this, the file_is_dev_zero() function can be provided, internal to mm, which allows for positive identification of these mappings.
Using this, first prevent any other mappings from mapping memory anonymously, then make these mappings truly anonymous and eliminate all code in the kernel that previously had to account for these strange beasts.
Finally, it adds userland VMA tests to assert the behaviour and selftests to assert expected merge behaviour.
v3:
* Added tags (thanks David! :)
* Moved the reworked mmap_prepare vm_ops comment to 3/6 where it is introduced and fixed a typo in it, as per David.
v2:
* Added tags (thanks everybody!)
* Reworked comment about mappings not setting themselves anon as per David.
* Fixed up test typo as per David.
* Fixed up test close() as per David.
https://lore.kernel.org/r/[email protected]
v1:
https://lore.kernel.org/r/[email protected]
---
Lorenzo Stoakes (ARM) (6):
mm: move drivers/char/mem.c to mm/char-mem.c
mm: implement file_is_dev_zero() to uniquely identify /dev/zero mm/vma: only permit MAP_PRIVATE /dev/zero to be mapped anonymous mm/vma: make MAP_PRIVATE-mapped /dev/zero mappings truly anonymous tools/testing/vma: add test to assert MAP_PRIVATE-/dev/zero is anon tools/testing/selftests/mm: add MAP_PRIVATE-/dev/zero merge tests
MAINTAINERS | 4 +- drivers/char/Makefile | 2 +- include/linux/mm.h | 10 +-- include/linux/pagemap.h | 3 +- mm/Makefile | 3 +- drivers/char/mem.c => mm/char-mem.c | 21 +++-- mm/internal.h | 20 +++-- mm/shmem.c | 2 +- mm/vma.c | 39 +++++++-- mm/vma.h | 3 - tools/testing/selftests/mm/merge.c | 95 ++++++++++++++++++++++ .../selftests/proc/proc-self-map-files-001.c | 2 +- .../selftests/proc/proc-self-map-files-002.c | 2 +- tools/testing/vma/include/dup.h | 10 ++- tools/testing/vma/shared.c | 9 ++ tools/testing/vma/tests/mmap.c | 37 +++++++++ 16 files changed, 220 insertions(+), 42 deletions(-)
---
base-commit: e3b5239afe1b8f0194db7436b17c33e94c1988c4
change-id: 20260902-map-private-dev-zero-ba36d76a2fc8
Best regards,
Signature · 1 line
Lorenzo Stoakes (ARM) <[email protected]>