Skip to content

mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms

SJ Park damon linux-kselftest linux-mm lkml stable 1 version Applied

Status from this message: [merged mm-stable] mm-damon-sysfs-set-next-refresh-jiffies-per-sysfs-context.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 10 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4mm/damon/tests/core-kunit: test committing psi goal to psi goalmm/damon/tests/core-kunit.h+7 -01 replyApplied
2/4mm/damon/core: handle uninitialized damos_quota_goal->last_psi_totalmm/damon/core.c mm/damon/tests/core-kunit.h+14 -81 replyApplied
3/4mm/damon/core: copy nid for eligible_mem_bp damos quota goal commitmm/damon/core.c+3 -04 repliesApplied
4/4mm/damon/sysfs: set next refresh jiffies per sysfs contextmm/damon/sysfs.c+5 -61 replyApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLian WangKunwu Chan
SeriesR-b T-b
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms

DAMOS quota goals commit unit test is mistakenly not testing a test case that was designed to test. DAMOS quota goals and DAMON sysfs refresh_ms file have bugs that can produce non critical but still unexpected behaviors. Fix the bugs.

Patch 1 fixes the DAMOS quota goals commit unit test to cover a mistakenly uncovered case. Patches 2 and 3 fix the bugs in DAMOS PSI goal initialization and eligible_mem_bp online commit, respectively. Patch 4 fixes the bug in DAMON sysfs refresh_ms file handling.

Changes from RFC v1.3
- RFC v1.3: https://lore.kernel.org/[email protected]
- Drop RFC tag.
- Rebase to latest mm-new.
Changes from RFC v1.2
- RFC v1.2: https://lore.kernel.org/[email protected]
- Fix last_psi_total underflow.
Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/[email protected]
- Fix quota goals commit unit test that was mistakenly missing a test case.
- Initialize last_psi_total as uninitialized at the beginning.
- Correct kunit test for changed last_psi_total initialization behavior. Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
(Mistakenly missed RFC tag)
- Fix build error.
- Add eligible_mem_bp nid commit fix.

SJ Park (4):
mm/damon/tests/core-kunit: test committing psi goal to psi goal mm/damon/core: handle uninitialized damos_quota_goal->last_psi_total mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit mm/damon/sysfs: set next refresh jiffies per sysfs context

 mm/damon/core.c             | 16 ++++++++++++++--
 mm/damon/sysfs.c            | 11 +++++------
 mm/damon/tests/core-kunit.h | 16 ++++++++++------
 3 files changed, 29 insertions(+), 14 deletions(-)

base-commit: ee125db0b1f24a2f6b04e3143ffe1a14324176fe

Signature · 1 line
2.47.3