Skip to content

mm/damon: cleanup code, add test cases, and update guidances in docs

SJ Park damon linux-doc linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] docs-abi-damon-recommend-subsystem-doc-instead-of-admin-guide.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 17 repliesApplied 12/12

Patches in v1 All 12 applied

#Subject and filesSizeRepliesApplied
1/12mm/damon/core: use damon_nr_samples_per_aggr() for max merge thresholdmm/damon/core.c+1 -21 replyApplied
2/12mm/damon/core: remove debug messagesmm/damon/core.c+0 -92 repliesApplied
3/12mm/damon/vaddr: remove a debug messagemm/damon/vaddr.c+3 -131 replyApplied
4/12mm/damon/core: validate number of probes in valid_probe_params()mm/damon/core.c+7 -01 replyApplied
5/12mm/damon/sysfs: remove probes number validationmm/damon/sysfs.c+1 -13 repliesApplied
6/12mm/damon/tests/core-kunit: extend set_regions() test for error casemm/damon/tests/core-kunit.h+10 -80 repliesApplied
7/12mm/damon/tests/core-kunit: test <=0 size damon_set_regions() inputsmm/damon/tests/core-kunit.h+14 -00 repliesApplied
8/12mm/damon/tests/core-kunit: test overlapping ranges for set_regions()mm/damon/tests/core-kunit.h+11 -01 replyApplied
9/12mm/damon/tests/core-kunit: test damon_nr_samples_per_aggr()mm/damon/tests/core-kunit.h+22 -04 repliesApplied
10/12selftests/damon/sysfs.sh: test hugepage_mem_bp quota goaltools/testing/selftests/damon/sysfs.sh+1 -01 replyApplied
11/12Docs/mm/damon/maintainer-profile: update AI review for Sashiko repliesDocumentation/mm/damon/maintainer-profile.rst+5 -140 repliesApplied
12/12Docs/ABI/damon: recommend subsystem doc instead of admin-guideDocumentation/ABI/testing/sysfs-kernel-mm-damon+1 -11 replyApplied

Reviews trailers per patch

8 of 12 patches have a Reviewed-by or Acked-by.

PatchKunwu Chan
1/12R-b
2/12
3/12R-b
4/12R-b
5/12R-b
6/12
7/12
8/12R-b
9/12R-b
10/12R-b
11/12
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] mm/damon: cleanup code, add test cases, and update guidances in docs

Misc cleanup, improvements and updates of code, test, and documents.

Patches 1-5 cleanup DAMON code. Patches 6-10 adds kunit and selftest test cases for recently fixed bugs and a new feature. Patches 11 and 12 update guidelines for AI review and what document to read, on DAMON documents.

Changes from RFC v1.2
- RFC v1.2: https://lore.kernel.org/[email protected]
- Drop RFC tag.
- Rebase to latest mm-new.
Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/[email protected]
- Fix a typo: s/alingment/alignment/.
- Add damon probes parameter validation cleanup (patches 4 and 5). Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
- Remove ctx parameter of __damon_va_init_regions().
- Fix damon_nr_samples_per_aggr() overflow kunit test.
- Rebase to the latest mm-new.

SJ Park (12):
mm/damon/core: use damon_nr_samples_per_aggr() for max merge threshold mm/damon/core: remove debug messages
mm/damon/vaddr: remove a debug message
mm/damon/core: validate number of probes in valid_probe_params() mm/damon/sysfs: remove probes number validation mm/damon/tests/core-kunit: extend set_regions() test for error case mm/damon/tests/core-kunit: test <=0 size damon_set_regions() inputs mm/damon/tests/core-kunit: test overlapping ranges for set_regions() mm/damon/tests/core-kunit: test damon_nr_samples_per_aggr() selftests/damon/sysfs.sh: test hugepage_mem_bp quota goal Docs/mm/damon/maintainer-profile: update AI review for Sashiko replies Docs/ABI/damon: recommend subsystem doc instead of admin-guide

 .../ABI/testing/sysfs-kernel-mm-damon         |  2 +-
 Documentation/mm/damon/maintainer-profile.rst | 19 ++----
 mm/damon/core.c                               | 19 +++---
 mm/damon/sysfs.c                              |  2 +-
 mm/damon/tests/core-kunit.h                   | 65 ++++++++++++++++---
 mm/damon/vaddr.c                              | 16 +----
 tools/testing/selftests/damon/sysfs.sh        |  1 +
 7 files changed, 76 insertions(+), 48 deletions(-)

base-commit: 52315e1a031f7370a286d6f6c805e2c8eab5abbc

Signature · 1 line
2.47.3