wifi: rtw88: usb: keep bmc traffic from exhausting the TX page pool
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 2 repliesIn review
- v23 patches 3 repliesSuperseded
- v12 patches 4 repliesSuperseded
Changes in v3 from the cover letter
- rebased on rtw-next
- 1/3: the refill macro comment now says what one interval buys, the bookkeeping comment is a single line and the block got the blank lines (Ping-Ke); Acked-by added
- 2/3: the IP/UDP test written in positive form (Ping-Ke)
- 3/3: unchanged, Acked-by added
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | wifi: rtw88: usb: bound what the driver feeds the after-DTIM queuedrivers/ drivers/ | +43 | 1 reply | |
| 2/3 | wifi: rtw88: usb: only let the frames a dozing station needs use the after-DTIM queuedrivers/ | +25 | 1 reply | |
| 3/3 | wifi: rtw88: widen the ATIM window while an AP interface is updrivers/ drivers/ | +4 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Ping-Ke Shih |
|---|---|
| 1/3 | A-b |
| 2/3 | A-b |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH rtw-next v3 0/3] wifi: rtw88: usb: keep bmc traffic from exhausting the TX page pool
From: Mehmet Fide <[email protected]>
An rtw88 USB AP with one station in power save and ordinary multicast chatter (mDNS, SSDP) starves its own TX page pool: every broadcast and multicast frame goes to the after-DTIM high queue, which drains a few frames per DTIM inside a 2 TU ATIM window, and the driver hands over as many as the network produces. On an RTL8822BU the free page count at 0x240 goes from 1803 to 16 in ~100 s and stays there for as long as the traffic lasts; nothing else gets out, nobody can join, the reserved page download fails ("error beacon valid"). Only a reboot recovers.
The series closes this from three sides:
1/3 bounds what the driver feeds the high queue (a small budget below
the measured drain rate, the excess leaves on the AC queue),
2/3 admits only the frames a dozing station actually needs to the
after-DTIM path (ARP, EAPOL, DHCP, the vendor driver's default "allow special" filter), everything else goes out at line rate,
3/3 widens the ATIM window to 0xa while an AP interface is up, as the
vendor driver does, so the high queue drains faster to begin with.
With 1/3 + 2/3 the pool stays at 1803 through a 180 s storm on the RTL8822BU, a DHCP flood still takes the after-DTIM path and is held by the budget, join/ping cycling without power save is unchanged (10/10). The beacon-early C2H that Ping-Ke found usable in AP mode is the long-term route to IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING; that is a separate series, this one does not depend on it.
v3 is the review of v2 only, no functional change, so the v2 bench results above still apply.
v1: https://lore.kernel.org/linux-wireless/[email protected]/
v2: https://lore.kernel.org/linux-wireless/[email protected]/
v3:
- rebased on rtw-next
- 1/3: the refill macro comment now says what one interval buys, the bookkeeping comment is a single line and the block got the blank lines (Ping-Ke); Acked-by added
- 2/3: the IP/UDP test written in positive form (Ping-Ke)
- 3/3: unchanged, Acked-by added
v2:
- 1/3: macro for the refill interval, 'budget' naming, refill bookkeeping rewritten and commented, blank lines (Ping-Ke)
- 2/3: classification from skb->protocol / ip_hdr() / udp_hdr() and the control port flag as in rtw89, SNAP parser gone, include order (Ping-Ke)
- 3/3: new, REG_ATIMWND 0xa in AP mode, default restored on stop (Ping-Ke)
Mehmet Fide (3):
wifi: rtw88: usb: bound what the driver feeds the after-DTIM queue
wifi: rtw88: usb: only let the frames a dozing station needs use the
after-DTIM queue
wifi: rtw88: widen the ATIM window while an AP interface is up
drivers/net/wireless/realtek/rtw88/mac80211.c | 2 + drivers/net/wireless/realtek/rtw88/reg.h | 2 + drivers/net/wireless/realtek/rtw88/usb.c | 66 +++++++++++++++++-- drivers/net/wireless/realtek/rtw88/usb.h | 5 ++ 4 files changed, 71 insertions(+), 4 deletions(-)
base-commit: f71dd599a98182d6bc34dce39977f928068ecd64
Signature · 1 line
2.55.0