Skip to content

quota: Verify special quota formats match sb type

Jan Kara linux-fsdevel linux-mm ocfs2-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* Use s_magic instead of s_type for superblock type checking

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ocfs2: Refuse to enable ocfs2 format for another filesystemfs/ocfs2/quota_local.c+4 -01 reply
2/2shmem: Refuse to enable tmpfs format for another filesystemmm/shmem_quota.c+5 -03 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJoseph QiHugh Dickins
1/2R-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] quota: Verify special quota formats match sb type

Hello,

here is v2 of the patches for fix quota crashes when quota format doesn't match filesystem type. I'm now using s_magic instead of s_type for superblock type checking as Hugh pointed out (thus I also didn't pick up OCFS2 guys' R-b tags because the patch is different now). Once reviewed, I can merge these patches through my tree as they are only quota related and very unlikely to clash with anything.

Changes since v1:
* Use s_magic instead of s_type for superblock type checking

Original cover letter:

There are certain quota formats that are created only for particular filesystems - ocfs2 and tmpfs quota formats in particular. Make sure these formats are indeed being enabled only for filesystem of appropriate type. Otherwise quota format operations can easily crash as was spotted by fuzz testing.

Honza

Previous versions: