Skip to content

KVM: selftests: Fix incremental build dependencies

Fuad Tabba cgroups kvm kvmarm linux-kselftest lkml 2 versions – Applied

Status from this message: Applied patch 1 to kvm-x86 fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesApplied
  2. v11 patch 3 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2KVM: selftests: Fix arm64 sysreg header dependenciestools/testing/selftests/kvm/Makefile.kvm+11 -52 replies
2/2selftests/cgroup: Make the object directory an order-only prerequisitetools/testing/selftests/cgroup/lib/libcgroup.mk+1 -11 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchMichal Koutný
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] KVM: selftests: Fix incremental build dependencies

Hi folks,

Changes since v1 [1]:
- Use FORCE for the sysreg header rule instead of duplicating the generator's inputs. (Oliver)
- Added patch 2, the same class of bug in libcgroup.mk, found while testing patch 1.

Two fixes for Makefile rules that name a directory where a file's mtime is what matters. The first is arm64-only: the sysreg header isn't regenerated on an incremental build when the sysreg table changes. The second is arch-independent: cgroup_util.o recompiles, and every test relinks, on the run after any rebuild in lib/. The two patches are independent.

I'd suggested v1 go through kvmarm as it was arm64-only. With patch 2 being generic, this one is addressed to kvm with kvmarm on Cc. Since the patches are independent, they can also go through separate trees if that's easier.

Based on Linux 7.3-rc1 (cee9395acd804).

Cheers,
/fuad

[1] https://lore.kernel.org/all/[email protected]/

Fuad Tabba (2):
KVM: selftests: Fix arm64 sysreg header dependencies selftests/cgroup: Make the object directory an order-only prerequisite

 tools/testing/selftests/cgroup/lib/libcgroup.mk |  2 +-
 tools/testing/selftests/kvm/Makefile.kvm        | 16 +++++++++++-----
 2 files changed, 12 insertions(+), 6 deletions(-)

base-commit: cee9395acd8043be0644b25c34bfa86623f2b935

Signature · 1 line
2.39.5