Skip to content

KVM: selftests: Fix maxnodes bugs and cleanup related code

Sean Christopherson kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7KVM: selftests: Account for kernel's off-by-one bug in NUMA node syscallstools/testing/selftests/kvm/guest_memfd_test.c tools/testing/selftests/kvm/include/numaif.h tools/testing/selftests/kvm/x86/xapic_ipi_test.c+13 -21 reply
2/7KVM: selftests: Fix maxnode argument to migrate_pages() in xapic_ipi_testtools/testing/selftests/kvm/x86/xapic_ipi_test.c+1 -10 replies
3/7KVM: selftests: use BITS_PER_TYPE() for NUMA maskstools/testing/selftests/kvm/x86/xapic_ipi_test.c+3 -30 replies
4/7KVM: selftests: Compute node masks on-demand in xAPIC IPI testtools/testing/selftests/kvm/include/numaif.h tools/testing/selftests/kvm/x86/xapic_ipi_test.c+30 -231 reply
5/7KVM: selftests: Add common helper to get mask+number of usable memory NUMA nodestools/testing/selftests/kvm/include/numaif.h tools/testing/selftests/kvm/x86/xapic_ipi_test.c+14 -41 reply
6/7KVM: selftests: Automatically run xAPIC IPI migration test when possibletools/testing/selftests/kvm/x86/xapic_ipi_test.c+27 -131 reply
7/7KVM: selftests: Skip xAPIC IPI migration test when forced but unsupportedtools/testing/selftests/kvm/x86/xapic_ipi_test.c+3 -21 reply

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchShivank Garg
1/7R-b
2/7
3/7
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] KVM: selftests: Fix maxnodes bugs and cleanup related code

This is a spin-off of Shivank's series[*] to fix "flaws" in KVM selftests handling of @maxnode in various sycalls. In quote because the flaw is that KVM selftests followed the docs, and the kernel has a longstanding, poorly documented off-by-one bug.

Along the way, massage the xAPIC IPI test to automatically run its page migration testcases when possible, because that's the entire reason the test exists.

I didn't included the guest_memfd changes that were the focus of Shivank's series, as they are bigger and more involved (I'll let Shivank tackle those).

[*] https://lore.kernel.org/all/[email protected]

Sean Christopherson (5):
KVM: selftests: Account for kernel's off-by-one bug in NUMA node
syscalls
KVM: selftests: Compute node masks on-demand in xAPIC IPI test
KVM: selftests: Add common helper to get mask+number of usable memory
NUMA nodes
KVM: selftests: Automatically run xAPIC IPI migration test when
possible
KVM: selftests: Skip xAPIC IPI migration test when forced but
unsupported

Shivank Garg (2):
KVM: selftests: Fix maxnode argument to migrate_pages() in
xapic_ipi_test
KVM: selftests: use BITS_PER_TYPE() for NUMA masks

 .../testing/selftests/kvm/guest_memfd_test.c  |  2 +-
 tools/testing/selftests/kvm/include/numaif.h  | 43 ++++++++++
 .../selftests/kvm/x86/xapic_ipi_test.c        | 78 +++++++++----------
 3 files changed, 83 insertions(+), 40 deletions(-)

base-commit: 76671054f9a1ff6abb976583cd8da37650acdc97

Signature · 1 line
2.55.0.970.g62bdec98f9-goog