Skip to content

RDMA/rxe: Fix TOCTOU heap overflow in get_srq_wqe

Bjoern Doebel linux-rdma stable 1 version Applied

Status from this message: Queued the series for 5.10, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4RDMA/rxe: Fix over copying in get_srq_wqedrivers/infiniband/sw/rxe/rxe_resp.c+8 -20 replies
2/4RDMA/rxe: Missing unlock on error in get_srq_wqe()drivers/infiniband/sw/rxe/rxe_resp.c+1 -00 replies
3/4RDMA/rxe: Use the correct size of wqe when processing SRQdrivers/infiniband/sw/rxe/rxe_resp.c+1 -10 replies
4/4RDMA/rxe: Fix TOCTOU heap overflow in get_srq_wqedrivers/infiniband/sw/rxe/rxe_resp.c+4 -20 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchMajd DibbinyBob PearsonZhu Yanjun
1/4
2/4R-b R-b
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 5.10.y 0/4] RDMA/rxe: Fix TOCTOU heap overflow in get_srq_wqe

Upstream commit 22b8fbded65b ("RDMA/rxe: Fix TOCTOU heap overflow in get_srq_wqe") fixes a heap buffer overflow in the rxe responder.

The fix does not apply to 5.10.y as-is because get_srq_wqe() there predates three earlier cleanups. This series therefore backports those prerequisites from 5.14 first, and then the actual fix:

1/4 ec0fa2445c18 RDMA/rxe: Fix over copying in get_srq_wqe
(context adjusted for 5.10)
2/4 36941dfe0e8c RDMA/rxe: Missing unlock on error in get_srq_wqe()
(clean cherry-pick)
3/4 e2a05339fa11 RDMA/rxe: Use the correct size of wqe when processing SRQ
(clean cherry-pick)
4/4 22b8fbded65b RDMA/rxe: Fix TOCTOU heap overflow in get_srq_wqe
(cherry-picked from the v6.1.178 backport 3cfa2a3adc51, context
adjusted)

Tested in the Amazon Linux kernel test suite.

Bjoern

Bob Pearson (2):
RDMA/rxe: Fix over copying in get_srq_wqe RDMA/rxe: Use the correct size of wqe when processing SRQ

Dan Carpenter (1):
RDMA/rxe: Missing unlock on error in get_srq_wqe()

Tristan Madani (1):
RDMA/rxe: Fix TOCTOU heap overflow in get_srq_wqe

 drivers/infiniband/sw/rxe/rxe_resp.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
Signature · 1 line
2.50.1