efi/libstub: Avoid UTF-16 conversion busywork
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | x86/boot: Drop pointless re-implementation of panic()arch/ arch/ arch/ | +1 | 0 replies | |
| 2/7 | lib/ucs2_string: Avoid WARN in library codelib/ | +1 | 0 replies | |
| 3/7 | efi/libstub: Use ucs2_string library for UTF-16 to UTF-8 conversiondrivers/ drivers/ drivers/ | +18 | 0 replies | |
| 4/7 | efi/libstub: Avoid efi_puts() for compile time constant stringsdrivers/ drivers/ | +5 | 0 replies | |
| 5/7 | efi/libstub: Output UTF-16 directly from vsnprintf()drivers/ drivers/ drivers/ | +19 | 1 reply | |
| 6/7 | efi/libstub: Add support for printing human readable GUIDsdrivers/ | +35 | 0 replies | |
| 7/7 | efi/libstub: Add efi_snprintf() to construct wide stringsdrivers/ drivers/ | +12 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] efi/libstub: Avoid UTF-16 conversion busywork
The EFI libstub performs some redundant conversions between UTF-16 and UTF-8 and back again, which includes dealing with surrogate pairs, which UEFI implementations themselves simply ignore.
So drop all the homegrown code, and use the existing UCS-2 (== UTF-16 without surrogate pairs) library code where conversion to UTF-8 is actually needed (the kernel command line).
The remaining handling involves the EFI console, which supports wide characters natively, so just use those directly.
Ard Biesheuvel (7):
x86/boot: Drop pointless re-implementation of panic() lib/ucs2_string: Avoid WARN in library code
efi/libstub: Use ucs2_string library for UTF-16 to UTF-8 conversion efi/libstub: Avoid efi_puts() for compile time constant strings efi/libstub: Output UTF-16 directly from vsnprintf() efi/libstub: Add support for printing human readable GUIDs efi/libstub: Add efi_snprintf() to construct wide strings
arch/x86/boot/compressed/error.c | 19 --- arch/x86/boot/compressed/error.h | 1 - arch/x86/boot/compressed/mem.c | 2 +- drivers/firmware/efi/libstub/Makefile | 3 +- drivers/firmware/efi/libstub/efi-stub-helper.c | 59 +++----- drivers/firmware/efi/libstub/efistub.h | 6 +- drivers/firmware/efi/libstub/gop.c | 6 +- drivers/firmware/efi/libstub/printk.c | 93 ++---------- drivers/firmware/efi/libstub/vsprintf.c | 148 +++++++------------- lib/ucs2_string.c | 2 +- 10 files changed, 87 insertions(+), 252 deletions(-)
Signature · 1 line
2.47.3