read proc/pid/smaps_rollup under per-vma lock
Status from this message: [merged mm-stable] selftests-proc-add-proc-pid-smaps_rollup-tearing-tests.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 1 replyApplied 7/7
- v47 patches 9 repliesSuperseded
- v37 patches 32 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 5 patches | 37 replies | Superseded |
Patches in v5 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | proc/task_mmu: remove unnecessary helpersfs/ | +17 | 0 replies | Applied |
| 2/7 | proc/task_mmu: remove unnecessary inlines in function definitionsfs/ | +19 | 0 replies | Applied |
| 3/7 | proc/task_mmu: clarify shmem mapping walk conditions in smap_gather_stats()fs/ | +9 | 0 replies | Applied |
| 4/7 | proc/task_mmu: remove special-casing of smap_gather_stats() start parameterfs/ | +35 | 0 replies | Applied |
| 5/7 | proc/task_mmu: change proc_get_vma() to stop returning gate VMA at the endfs/ | +23 | 0 replies | Applied |
| 6/7 | proc/task_mmu: read proc/pid/smaps_rollup under per-vma lockfs/ | +63 | 0 replies | Applied |
| 7/7 | selftests/proc: add /proc/pid/smaps_rollup tearing teststools/ | +181 | 0 replies | Applied |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Liam R. Howlett (Oracle) | Lorenzo Stoakes (ARM) | Usama Arif | David Hildenbrand (Arm) |
|---|---|---|---|---|
| 1/7 | R-b | R-b | A-b | A-b |
| 2/7 | R-b | R-b | A-b | A-b |
| 3/7 | R-b | A-b | ||
| 4/7 | R-b | A-b | ||
| 5/7 | R-b | A-b | ||
| 6/7 | R-b | |||
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v5 0/7] read proc/pid/smaps_rollup under per-vma lock
proc/pid/smaps_rollup can be read using the combination of RCU and VMA read locks, similar to proc/pid/{maps|smaps|numa_maps}. RCU is required to safely traverse the VMA tree and VMA lock stabilizes the VMA being processed and the pagetable walk.
Note that we have to keep the logic to drop mmap_lock on contention because even when using per-VMA locks we might have to fall back to holding the mmap_lock.
The first 5 patches are cleanups making later change simpler. The main change is in patch 6. Patch 7 extends existing proc-maps-race tearing test to verify smaps_rollup content.
Changes since v4 [1]:
Patch 2:
- Fixed warnings with CONFIG_PROC_PAGE_MONITOR=n
- Fixed a typo in the changelog
Patch 3:
- Add Reviewed-by and Acked-by, per Lorenzo Stoakes and David Hildenbrand
Patch 3:
- Add Reviewed-by and Acked-by, per Lorenzo Stoakes and David Hildenbrand
[1] https://lore.kernel.org/all/[email protected]/
Suren Baghdasaryan (7):
proc/task_mmu: remove unnecessary helpers
proc/task_mmu: remove unnecessary inlines in function definitions proc/task_mmu: clarify shmem mapping walk conditions in
smap_gather_stats()
proc/task_mmu: remove special-casing of smap_gather_stats() start
parameter
proc/task_mmu: change proc_get_vma() to stop returning gate VMA at the
end
proc/task_mmu: read proc/pid/smaps_rollup under per-vma lock selftests/proc: add /proc/pid/smaps_rollup tearing tests
fs/proc/task_mmu.c | 341 ++++++++---------- tools/testing/selftests/proc/proc-maps-race.c | 186 +++++++++- 2 files changed, 336 insertions(+), 191 deletions(-)
base-commit: 854157fc9d011b8dd5a1a86a237447e28d681eb9
Signature · 1 line
2.55.0.1082.g2b9226bbc0-goog