Skip to content

neighbour: Small fixes for RTM_{GET,SET}NEIGHTBL.

Kuniyuki Iwashima netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesApplied 4/4
  2. v24 patches 5 repliesSuperseded
  3. v14 patches 5 repliesSuperseded

Changes in v3 from the cover letter

* Patch 2
* Nest min/max inside checks: in rt-neigh.yaml

Patches in v3 All 4 applied

#Subject and filesSizeRepliesApplied
1/4neighbour: Add missing RCU annotation for neightbl_dump_info().net/core/neighbour.c+5 -20 repliesApplied
2/4neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS.Documentation/netlink/specs/rt-neigh.yaml Documentation/networking/ip-sysctl.rst net/core/neighbour.c+17 -51 replyApplied
3/4neighbour: Don't render blackhole_netdev via RTM_GETNEIGHTBL.net/core/neighbour.c+1 -10 repliesApplied
4/4neighbour: Skip default parms when resumed in neightbl_dump_info().net/core/neighbour.c+8 -30 repliesApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchIdo Schimmel
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net 0/4] neighbour: Small fixes for RTM_{GET,SET}NEIGHTBL.

While working on the follow-up suggested here,

https://lore.kernel.org/netdev/20260902143023.GA3966681@shredder/

I found a few bugs in RTM_GETNEIGHTBL and RTM_SETNEIGHTBL, which this series fixes.

Patch 1, 3, 4 will conflict with net-next in neightbl_dump_info() due to removal of net_eq() below:

	p = list_next_entry(&tbl->parms, list);
	list_for_each_entry_from_rcu(p, &tbl->parms_list, list) {
		if (!net_eq(neigh_parms_net(p), net))
			continue;

Note also that currently neigh_proc_dointvec_ms_jiffies_positive() is buggy and does not enforce min/max, and it needs this fix:

https://lore.kernel.org/linux-fsdevel/[email protected]/

Changes:
v3:
* Patch 2
* Nest min/max inside checks: in rt-neigh.yaml

v2: https://lore.kernel.org/netdev/[email protected]/
* Patch 1
* Use list_for_each_entry_rcu() and skip the default parms
* Patch 2
* Clarify the attribute is for NTF_MANAGED
* Update docs, rt-neigh.yaml and ip-sysctl.rst

v1: https://lore.kernel.org/netdev/[email protected]/

Kuniyuki Iwashima (4):
neighbour: Add missing RCU annotation for neightbl_dump_info().
neighbour: Enforce min/max to NDTPA_INTERVAL_PROBE_TIME_MS.
neighbour: Don't render blackhole_netdev via RTM_GETNEIGHTBL.
neighbour: Skip default parms when resumed in neightbl_dump_info().

 Documentation/netlink/specs/rt-neigh.yaml |  3 ++
 Documentation/networking/ip-sysctl.rst    |  2 +-
 net/core/neighbour.c                      | 35 +++++++++++++++++------
 3 files changed, 30 insertions(+), 10 deletions(-)
Signature · 1 line
2.55.0.1003.g10538fe699-goog

Read the cover letter in its thread