RFC blk-iocost: BPF struct_ops cost model
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v14 RFC Latest4 patches 1 replyIn review
- v13 RFC4 patches 5 repliesSuperseded
- v12 RFC4 patches 6 repliesSuperseded
Earlier versions · 12
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v11 RFC | 5 patches | 15 replies | Superseded | |
| v10 RFC | 4 patches | 12 replies | Superseded | |
| v9 RFC | 4 patches | 1 reply | Superseded | |
| v8 RFC | 4 patches | 9 replies | Superseded | |
| v7 RFC | 4 patches | 10 replies | Superseded | |
| v6 RFC | 5 patches | 6 replies | Superseded | |
| v5 RFC | 5 patches | 3 replies | Superseded | |
| v4 RFC posting 2/2 | 5 patches | 1 reply | Superseded | |
| v4 RFC posting 1/2 | 0 of 5 patches | 0 replies | Superseded | |
| v3 RFC | 5 patches | 2 replies | Superseded | |
| v2 RFC | 5 patches | 1 reply | Superseded | |
| v1 RFC | 8 patches | 7 replies | Superseded |
Changes in v14 from the cover letter
- p1: stop updating attached and attached_link under ioc->lock; rq_qos_mutex already orders all their accessors (review from tj)
- p1: name the calc_cost flags enum iocost_calc_flags and rename ioc_model()/model to ioc_bpf_model()/bpf_model so that the builtin model isn't called a NULL model (review from tj)
- p1: document why iocost holds its own model reference, the field locking and the merge flag semantics, and reword the commit message to describe guarantees instead of code paths (review from tj)
- p1: clear the autop stepping timestamps when a BPF model is attached; without this, the timestamps from before the attach survive until a model=linear switchback and can trigger an immediate profile step on that stale pre-attach evidence (report from sashiko)
- p1: align the BPF pricing scope with the builtin model:
dataless bios with no flush state and ops other than reads, writes and zone appends cost nothing, completion-time sizing prices reads, writes and zone appends, and a dead owning map no longer reports -EBUSY (report from sashiko)
- p3: probe the iocost_ioc_tick tracepoint, unwind the private mount namespace on setup failure, report fopen errors faithfully and fix an inverted posix_memalign() assertion that made the streams test skip its whole IO block (report from sashiko)
- p2/p4: document the iocost_ioc_tick fields in the trace header and extend the io.cost.model docs with the dev supply and the -ENODEV attach conditions (report from sashiko)
Patches in v14 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | blk-iocost: add BPF struct_ops cost model supportblock/ block/ | +342 | 0 replies | |
| 2/4 | blk-iocost: add iocost_ioc_tick tracepoint for per-period device summaryMAINTAINERS block/ include/ | +76 | 0 replies | |
| 3/4 | selftests/bpf: add iocost cost model testtools/ tools/ tools/ +1 more | +1332 | 0 replies | |
| 4/4 | docs: cgroup-v2: document the iocost BPF cost model attachmentDocumentation/ | +47 | 0 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Alexei Starovoitov | Tejun Heo |
|---|---|---|
| 1/4 | A-b | |
| 2/4 | A-b | |
| 3/4 | ||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v14 0/4] blk-iocost: BPF struct_ops cost model
From: Tao Cui <[email protected]>
This series lets a BPF program take over the cost model of one device. The BPF model provides calc_cost() for charged IOs plus two transfer coefficients for the completion-time sizing, io.cost.model selects between the attached model and the builtin one, and enabling and disabling the controller stays with io.cost.qos.
The builtin model is a linear formula derived from a handful of device parameters, and the right formula is device specific. A BPF model can be adapted to the device and updated without rebuilding the kernel.
The series is based on next-20261117.
Changes since v13:
- p1: stop updating attached and attached_link under ioc->lock; rq_qos_mutex already orders all their accessors (review from tj)
- p1: name the calc_cost flags enum iocost_calc_flags and rename ioc_model()/model to ioc_bpf_model()/bpf_model so that the builtin model isn't called a NULL model (review from tj)
- p1: document why iocost holds its own model reference, the field locking and the merge flag semantics, and reword the commit message to describe guarantees instead of code paths (review from tj)
- p1: clear the autop stepping timestamps when a BPF model is attached; without this, the timestamps from before the attach survive until a model=linear switchback and can trigger an immediate profile step on that stale pre-attach evidence (report from sashiko)
- p1: align the BPF pricing scope with the builtin model:
dataless bios with no flush state and ops other than reads, writes and zone appends cost nothing, completion-time sizing prices reads, writes and zone appends, and a dead owning map no longer reports -EBUSY (report from sashiko)
- p3: probe the iocost_ioc_tick tracepoint, unwind the private mount namespace on setup failure, report fopen errors faithfully and fix an inverted posix_memalign() assertion that made the streams test skip its whole IO block (report from sashiko)
- p2/p4: document the iocost_ioc_tick fields in the trace header and extend the io.cost.model docs with the dev supply and the -ENODEV attach conditions (report from sashiko)
Tested on next-20261117 (qemu x86_64): the selftests pass, and the 2x example model doubles the charged cost over the builtin on a rotational device (2.00x measured), returning to 1.00x after "model=linear".
Tao Cui (4):
blk-iocost: add BPF struct_ops cost model support
blk-iocost: add iocost_ioc_tick tracepoint for per-period device
summary
selftests/bpf: add iocost cost model test
docs: cgroup-v2: document the iocost BPF cost model attachment
Documentation/admin-guide/cgroup-v2.rst | 55 +- MAINTAINERS | 1 + block/Kconfig | 4 + block/blk-iocost.c | 360 ++++++- include/trace/events/iocost.h | 57 ++ tools/testing/selftests/bpf/config | 2 + .../selftests/bpf/prog_tests/iocost_model.c | 947 ++++++++++++++++++ .../selftests/bpf/progs/iocost_model.c | 188 ++++ tools/testing/selftests/bpf/progs/iocost_ms.c | 195 ++++ 9 files changed, 1797 insertions(+), 12 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/iocost_model.c create mode 100644 tools/testing/selftests/bpf/progs/iocost_model.c create mode 100644 tools/testing/selftests/bpf/progs/iocost_ms.c