Skip to content

mfd: qcom-pm8008: support PMICs with no interrupt line

Oleg Keri linux-arm-msm linux-devicetree lkml mfd 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: mfd: qcom,pm8008: make the interrupt line optionalDocumentation/devicetree/bindings/mfd/qcom,pm8008.yaml+4 -30 replies
2/2mfd: qcom-pm8008: support PMICs with no interrupt linedrivers/mfd/qcom-pm8008.c+40 -232 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] mfd: qcom-pm8008: support PMICs with no interrupt line

The camera PMIC on the Lenovo Yoga Slim 7x Gen 11 (Qualcomm Snapdragon X2 Elite, glymur) has no interrupt line routed on the board. That is not a wiring omission - the part has no INT pin brought out in this design, and the sensor resets are driven from TLMM instead.

The part is a PM8010; this board describes it with the qcom,pm8008 compatible, which is what binds the driver touched here.

qcom-pm8008 currently requires an interrupt: the binding marks it required and the driver fails probe without one, so the PMIC cannot be described at all on such a board even though everything it provides - the regulators - works fine without interrupts.

Patch 1 relaxes the binding, patch 2 makes the driver treat the interrupt as optional and skip the regmap-irq chip when it is absent. Boards that do wire the interrupt are unaffected.

Tested on a Lenovo Yoga Slim 7x Gen 11 (DMI 83QR, "Yoga Slim 7 14Q8Y11"), where this PMIC powers an OV08X40 sensor.

The DT change that describes this PMIC is not part of this series; it lands with the board DTS, which is being upstreamed separately.

Oleg Keri (2):
dt-bindings: mfd: qcom,pm8008: make the interrupt line optional
mfd: qcom-pm8008: support PMICs with no interrupt line

 .../devicetree/bindings/mfd/qcom,pm8008.yaml  |  7 +--
 drivers/mfd/qcom-pm8008.c                     | 52 ++++++++++++-------
 2 files changed, 38 insertions(+), 21 deletions(-)
Signature · 3 lines
2.55.0

base-commit: df2908090cda368b01ff43709f51890076c56157