drm/xe/mmio_gem: fix fault handler and destroy path
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest8 patches 2 repliesIn review
- v48 patches 3 repliesSuperseded
Changes in v5 from the cover letter
- Tweak "convert PCI barrier mmap to use xe_mmio_gem" to use scoped_guard()
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | drm/xe/mmio_gem: forbid VMA splitdrivers/ | +10 | 0 replies | |
| 2/8 | drm/xe/mmio_gem: use write-back mapping for dummy pagedrivers/ | +5 | 0 replies | |
| 3/8 | drm/xe/mmio_gem: simplify fault handler loopdrivers/ | +6 | 0 replies | |
| 4/8 | drm/xe/mmio_gem: Revoke drm_vma_node on xe_mmio_gem destroydrivers/ drivers/ | +4 | 0 replies | |
| 5/8 | drm/xe/mmio_gem: cache the dummy page per objectdrivers/ | +16 | 0 replies | |
| 6/8 | drm/xe/mmio_gem: fix destroy flowdrivers/ | +35 | 1 reply | |
| 7/8 | drm/xe/mmio_gem: reject VM_EXEC and drop VM_DONTCOPYdrivers/ | +5 | 0 replies | |
| 8/8 | drm/xe: convert PCI barrier mmap to use xe_mmio_gemdrivers/ drivers/ drivers/ +1 more | +61 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Matthew Auld | Ilia Levi | Thomas Hellström |
|---|---|---|---|
| 1/8 | R-b | ||
| 2/8 | R-b | ||
| 3/8 | R-b | ||
| 4/8 | R-b | ||
| 5/8 | R-b | ||
| 6/8 | R-b | ||
| 7/8 | R-b | ||
| 8/8 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v5 0/8] drm/xe/mmio_gem: fix fault handler and destroy path
Picking up the series from Ilia:
https://lore.kernel.org/intel-xe/[email protected]/
This series fixes several issues in xe_mmio_gem, introduced by 1ffcf8b8ae8a ("drm/xe: Support for mmap-ing mmio regions"):
split VMA handling, WB/UC aliasing of the dummy page, a rb-tree leak on destroy, dummy page accumulation, and use-after-free / MMIO access after destroy. It also converts the existing PCI barrier mmap to build on xe_mmio_gem now that the infrastructure is in place.
v5 (Thomas):
- Tweak "convert PCI barrier mmap to use xe_mmio_gem" to use scoped_guard()
v4:
- One extra patch for VM_EXEC and DONTCOPY.
- Tweak the commit message in "use write-back mapping for dummy page" wrt x86.
v3: (Matt Auld)
- New patch using the xe_mmio_gem infra for PCI barrier mmap
- New patch for rejecting VMA split
- Using dma_resv lock for synchronization
- SIGBUS instead of dummy page on access after destroy
- Some changes in patch splitting (e.g. the vm_pgoff handling now lives
in the destroy-flow patch alongside the zap that needs it)
v2:
- New patch 1/5: fix dummy page WB/UC aliasing (Sashiko)
- Patch 2/5: no longer modifies xe_mmio_gem_vm_fault_dummy_page() (handled by 1/5)
- Patch 3/5: unchanged
- Patch 4/5: compute pfn inside scoped_guard
- Patch 5/5: adapt to xe_mmio_gem_vm_fault_dummy_page() signature change, fix "objecthas" typo
Signature · 1 line
2.55.0