Skip to content

irqchip/gic-v3: Lifetime and range fixes in the GICv3 and ITS drivers

Fuad Tabba linux-arm-kernel lkml stable 1 version Applied

Status from this message: The following commit has been merged into the irq/drivers branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3irqchip/gic-v3: Release the partition node in gic_irq_get_fwspec_info()drivers/irqchip/irq-gic-v3.c+4 -30 replies
2/3irqchip/gic-v3-its: Don't clamp nvecs to zero when id_bits is 32drivers/irqchip/irq-gic-v3-its.c+1 -10 replies
3/3irqchip/gic-v3-its: Clear vpt_page after freeing the pending tabledrivers/irqchip/irq-gic-v3-its.c+1 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarc ZyngierRadu RendecZenghui Yu (Huawei)yang
SeriesR-b R-b R-b T-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] irqchip/gic-v3: Lifetime and range fixes in the GICv3 and ITS drivers

Hi folks,

Three fixes to the GICv3 and ITS drivers, from reviewing the GIC series floating around and chasing down Sashiko's reports.

The first releases the partition node that gic_irq_get_fwspec_info() takes from of_find_node_by_phandle() and never puts. Sashiko raised it on an of/irq patch of mine, and I said a fix was forthcoming [1].

The second widens the per-device MSI clamp, which truncates to zero when GITS_TYPER.ID_bits is at its maximum and then denies every MSI on that ITS. I couldn't find an implementation that reports that maximum, so this is one value at the edge rather than something anyone is hitting. It carries Cc: stable because the commit it fixes was itself backported, so drop the tag if you'd rather.

The third clears vpt_page once its_vpe_teardown() has freed it, so the NULL guard holds if teardown runs again on the same vPE.

Based on Linux 7.3-rc2 (df2908090cda3).

Cheers,
/fuad

[1] https://lore.kernel.org/all/CA+EHjTx7eP_30vP47=UFk_wMAut-2uf+2DF-MZqn2SLE_k-8qg@mail.gmail.com/

Fuad Tabba (3):
irqchip/gic-v3: Release the partition node in
gic_irq_get_fwspec_info()
irqchip/gic-v3-its: Don't clamp nvecs to zero when id_bits is 32 irqchip/gic-v3-its: Clear vpt_page after freeing the pending table

 drivers/irqchip/irq-gic-v3-its.c | 3 ++-
 drivers/irqchip/irq-gic-v3.c     | 7 ++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

base-commit: df2908090cda368b01ff43709f51890076c56157

Signature · 1 line
2.39.5