efi/libstub: Avoid UTF-16 conversion busywork
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 2 repliesIn review
- v210 patches 18 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | lib/ucs2_string: Drop arbitrary input size limit and associated WARN()lib/ | +1 | 0 replies | |
| 2/9 | lib/ucs2_string: Suppress modinfo when __DISABLE_EXPORTS is setlib/ | +2 | 0 replies | |
| 3/9 | lib/ucs2_string: Split out ucs2_as_utf8_l() taking a separate limitinclude/ lib/ | +18 | 0 replies | |
| 4/9 | efi/libstub: Use ucs2_string library for UTF-16 to UTF-8 conversiondrivers/ drivers/ drivers/ | +39 | 0 replies | |
| 5/9 | efi/libstub: Avoid efi_puts() for compile time constant stringsdrivers/ drivers/ | +5 | 0 replies | |
| 6/9 | efi/libstub: Output UTF-16 directly from vsnprintf()drivers/ drivers/ drivers/ | +22 | 0 replies | |
| 7/9 | efi/libstub: Add support for printing human readable GUIDsdrivers/ | +34 | 0 replies | |
| 8/9 | efi/libstub: Add efi_snprintf() to construct wide stringsdrivers/ drivers/ | +12 | 0 replies | |
| 9/9 | efi/libstub: add initial Boot Loader Interface supportdrivers/ drivers/ drivers/ +3 more | +114 | 0 replies |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Vincent Mailhol |
|---|---|
| Series | R-b |
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/9] efi/libstub: Avoid UTF-16 conversion busywork
From: Ard Biesheuvel <[email protected]>
The EFI libstub performs some redundant conversions between UTF-16 and UTF-8 and back again, which includes dealing with surrogate pairs, which UEFI implementations themselves simply ignore.
So drop all the homegrown code, and use the existing UCS-2 (== UTF-16 without surrogate pairs) library code where conversion to UTF-8 is actually needed (the kernel command line).
The remaining handling involves the EFI console, which supports wide characters natively, so just use those directly.
Changes since v2 [1]:
- drop x86 specific patch, it has been split out into a separate series
[2]
- handle truncated output of ucs2_as_utf8() in the middle of a multibyte character correctly
- improve ucs2_as_utf8() documentation
- tweaks to the commit logs
Changes since v1 [0]:
- drop size limit from ucs2_strscpy() instead of just the WARN()
- suppress modinfo sections from ucs2_string when __DISABLE_EXPORTS is defined
- allow the input limit and max output size to be passed separately to ucs2_to_utf8()
- reimplement efi_convert_cmdline() to optimize the common case, and only process the input character by character if its size exceeds COMMAND_LINE_SIZE
- use memcpy() to avoid strscpy() semantics in handling of %ls
- incorporate Vincent's patch (which inspired this work) for completeness
[0] https://lore.kernel.org/all/[email protected]
[1] http://lore.kernel.org/r/[email protected]
[2] http://lore.kernel.org/r/[email protected]
Ard Biesheuvel (8):
lib/ucs2_string: Drop arbitrary input size limit and associated WARN() lib/ucs2_string: Suppress modinfo when __DISABLE_EXPORTS is set lib/ucs2_string: Split out ucs2_as_utf8_l() taking a separate limit efi/libstub: Use ucs2_string library for UTF-16 to UTF-8 conversion efi/libstub: Avoid efi_puts() for compile time constant strings efi/libstub: Output UTF-16 directly from vsnprintf() efi/libstub: Add support for printing human readable GUIDs efi/libstub: Add efi_snprintf() to construct wide strings
Vincent Mailhol (1):
efi/libstub: add initial Boot Loader Interface support
drivers/firmware/efi/libstub/Makefile | 3 +- drivers/firmware/efi/libstub/bli.c | 87 ++++++++++++ drivers/firmware/efi/libstub/efi-stub-helper.c | 98 +++++-------- drivers/firmware/efi/libstub/efi-stub.c | 1 + drivers/firmware/efi/libstub/efistub.h | 8 +- drivers/firmware/efi/libstub/gop.c | 6 +- drivers/firmware/efi/libstub/printk.c | 95 ++----------- drivers/firmware/efi/libstub/vsprintf.c | 149 +++++++------------- drivers/firmware/efi/libstub/x86-stub.c | 1 + include/linux/efi.h | 22 +++ include/linux/ucs2_string.h | 11 +- lib/ucs2_string.c | 19 +-- 12 files changed, 242 insertions(+), 258 deletions(-) create mode 100644 drivers/firmware/efi/libstub/bli.c
Signature · 1 line
2.55.0.1032.g73a4cd73de-goog