rpmb: Fix request serialisation and teardown races
Status from this message: Applied to 7.4/scsi-fixes, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 3 repliesApplied
- v53 patches 3 repliesSuperseded
- v43 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 1 patch | 0 replies | Superseded |
Changes in v6 from the cover letter
- Rebase onto mkp/scsi.git for-next.
- 1/3: clear descr.route_frames under rdev->lock instead of dead flag.
- 2/3: pin sdev_gendev via get_device(), drop Bean's tag on 1/3, 2/3.
- v5: https://lore.kernel.org/r/[email protected]
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | rpmb: core: Guard frame requests and teardown with mutexdrivers/ include/ | +21 | 1 reply | |
| 2/3 | scsi: ufs: rpmb: Decouple device lifecycle from devres to avoid UAFdrivers/ | +44 | 0 replies | |
| 3/3 | scsi: ufs: rpmb: Drop the unregistered ufs_rpmb busdrivers/ | +0 | 1 reply |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Bean Huo | Alexey Charkov |
|---|---|---|
| 1/3 | T-b | |
| 2/3 | ||
| 3/3 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/3] rpmb: Fix request serialisation and teardown races
Jens, Martin,
Patch 1/3 serializes requests and provider unregistration in drivers/misc/rpmb-core.c. Patches 2/3 and 3/3 fix UFS RPMB device lifetime and drop the unregistered bus in drivers/ufs/core/ufs-rpmb.c so regions register again after commit 36f35b8df697 ("driver core: reject devices with unregistered buses").
Patches 2/3 and 3/3 depend on 1/3 at runtime to avoid a use-after-free on host unbind. Jens, if 1/3 looks good to you, could you give an Acked-by so Martin can take all three patches in order through the SCSI tree?
Changes since v5:
- Rebase onto mkp/scsi.git for-next.
- 1/3: clear descr.route_frames under rdev->lock instead of dead flag.
- 2/3: pin sdev_gendev via get_device(), drop Bean's tag on 1/3, 2/3.
- v5: https://lore.kernel.org/r/[email protected]
Stanley Jhu (3):
rpmb: core: Guard frame requests and teardown with mutex
scsi: ufs: rpmb: Decouple device lifecycle from devres to avoid UAF
scsi: ufs: rpmb: Drop the unregistered ufs_rpmb bus
drivers/misc/rpmb-core.c | 20 ++++++++- drivers/ufs/core/ufs-rpmb.c | 84 +++++++++++++++++++------------------ include/linux/rpmb.h | 3 ++ 3 files changed, 65 insertions(+), 42 deletions(-)
base-commit: 0fc91e802801819a0c51d30b6eecac63ab4f85d2
Signature · 1 line
2.56.0.567.gdb80ae8cd5-goog