ASoC: mediatek: mt8189: Improve error handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest12 patches 2 repliesIn review
- v213 patches 19 repliesSuperseded
- v113 patches 4 repliesSuperseded
Changes in v3 from the cover letter
- Add Angelo's Reviewed-by tag.
- Restore the existing afe->regmap checks,
making the separate patch for missing regmap unnecessary.
- Do not pre-initialize ret; set ret = 0 in the default case throughout the series.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | ASoC: mediatek: mt8189: Propagate APLL enable errorssound/ | +56 | 0 replies | |
| 2/12 | ASoC: mediatek: mt8189: Propagate MCK enable errorssound/ | +11 | 0 replies | |
| 3/12 | ASoC: mediatek: mt8189: Validate MCK IDsound/ | +2 | 0 replies | |
| 4/12 | ASoC: mediatek: mt8189: Propagate reg_rw clock errorssound/ | +25 | 0 replies | |
| 5/12 | ASoC: mediatek: mt8189: Use dev_err_probe() for clock errorssound/ | +3 | 0 replies | |
| 6/12 | ASoC: mediatek: mt8189: Propagate runtime resume errorssound/ | +26 | 0 replies | |
| 7/12 | ASoC: mediatek: mt8189: Remove redundant error messagesound/ | +5 | 0 replies | |
| 8/12 | ASoC: mediatek: mt8189: Propagate APLL errorssound/ | +5 | 0 replies | |
| 9/12 | ASoC: mediatek: mt8189: Propagate MCLK errorssound/ | +5 | 0 replies | |
| 10/12 | ASoC: mediatek: mt8189: Validate sysclk frequencysound/ | +3 | 0 replies | |
| 11/12 | ASoC: mediatek: mt8189: Propagate TDM clock errorssound/ | +10 | 0 replies | |
| 12/12 | ASoC: mediatek: mt8189: Validate TDM MCLK frequencysound/ | +3 | 0 replies |
Reviews trailers per patch
7 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | AngeloGioacchino Del Regno |
|---|---|
| Series | R-b |
| 1/12 | |
| 2/12 | |
| 3/12 | R-b |
| 4/12 | |
| 5/12 | R-b |
| 6/12 | R-b |
| 7/12 | R-b |
| 8/12 | |
| 9/12 | R-b |
| 10/12 | R-b |
| 11/12 | |
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 00/12] ASoC: mediatek: mt8189: Improve error handling
From: bui duc phuc <[email protected]>
Hi all,
This series addresses part of the error handling in the MT8189 AFE driver.
It propagates errors from clock operations and runtime resume, validates clock parameters, and removes redundant error messages.
In v2, there was discussion about checking the return value of regmap_update_bits(). While opinions differed, the existing driver already checks it in mt8189_afe_enable_top_cg(), which is used by mt8189_apll1_enable() and mt8189_apll2_enable() touched by this series.
Therefore, I keep these checks and add the corresponding error paths for consistency.
Compile-tested only.
Link v1 :
https://lore.kernel.org/all/[email protected]/
Link v2:
https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Update the names of the goto labels.
- Check for zero frequency since freq is unsigned.
Changes in v3:
- Add Angelo's Reviewed-by tag.
- Restore the existing afe->regmap checks,
making the separate patch for missing regmap unnecessary.
- Do not pre-initialize ret; set ret = 0 in the default case throughout the series.
Best regards,
Phuc
bui duc phuc (12):
ASoC: mediatek: mt8189: Propagate APLL enable errors
ASoC: mediatek: mt8189: Propagate MCK enable errors
ASoC: mediatek: mt8189: Validate MCK ID
ASoC: mediatek: mt8189: Propagate reg_rw clock errors
ASoC: mediatek: mt8189: Use dev_err_probe() for clock errors
ASoC: mediatek: mt8189: Propagate runtime resume errors
ASoC: mediatek: mt8189: Remove redundant error message
ASoC: mediatek: mt8189: Propagate APLL errors
ASoC: mediatek: mt8189: Propagate MCLK errors
ASoC: mediatek: mt8189: Validate sysclk frequency
ASoC: mediatek: mt8189: Propagate TDM clock errors
ASoC: mediatek: mt8189: Validate TDM MCLK frequency
sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 134 +++++++++++++++------ sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 45 ++++--- sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 18 ++- sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 19 ++- 4 files changed, 154 insertions(+), 62 deletions(-)
Signature · 1 line
2.43.0