tracing: Do not clean up hiter in mmiotrace read function
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest2 patches 0 repliesNew
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | tracing: Do not clean up hiter in mmiotrace read functionkernel/ | +0 | 0 replies | |
| 2/2 | tracing: Invert the logic in mmio_read() to get rid of the gotokernel/ | +4 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Masami Hiramatsu (Google) |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] tracing: Do not clean up hiter in mmiotrace read function
When the mmiotrace trace was first created, it allocated a descriptor in its pipe_open() method. Since there was no pipe_close() method when it was created (in May of 2008, and pipe_close() was added in December of 2009), it cleaned up the allocated descriptors in the read.
Now that the clean up is in the pipe_close() method that now exists, remove the clean up from the read as it is no longer needed.
Also simplify the code by inverting the early exit conditional into a conditional to perform the logic and get rid of the goto.
Changse since v1: https://lore.kernel.org/linux-trace-kernel/[email protected]/
- Broke it up into two patches. Nothing else changed.
Steven Rostedt (2):
tracing: Do not clean up hiter in mmiotrace read function
tracing: Invert the logic in mmio_read() to get rid of the goto
----
kernel/trace/trace_mmiotrace.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)