Skip to content

scsi: ufs: core: Handle devices declining optional Query IDNs

Stanley Jhu linux-scsi lkml 1 version Applied

Status from this message: Applied to 7.4/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2scsi: ufs: core: Fast-abort unsupported Query IDNsdrivers/ufs/core/ufshcd.c+23 -60 replies
2/2scsi: ufs: core: Dynamically disable timestamp on unsupported devicesdrivers/ufs/core/ufshcd.c include/ufs/ufs.h+8 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] scsi: ufs: core: Handle devices declining optional Query IDNs

JEDEC JESD220F specifies that a device which does not support an optional Query IDN returns QUERY_RESULT_INVALID_IDN (0xFD) in the Query Response UPIU.

The driver maps every non-zero Query response to -EINVAL and logs dev_err(). A device declining an optional IDN is spec-compliant, so this reports a failure that did not happen and keeps the retry loops resending a request the device will never accept. On UFS 4.0 parts that omit the Timestamp attribute it repeats on every boot and every resume.

A third model was recently proposed for UFS_DEVICE_QUIRK_NO_TIMESTAMP_SUPPORT; recognising the rejection at runtime avoids growing that table further.

Patch 1 decodes 0xFD as -EOPNOTSUPP across the query layer. Patch 2 uses that to stop reissuing the Timestamp write on devices that reject it.

Compile tested on arm64 (defconfig + SCSI_UFSHCD).

Stanley Jhu (2):
scsi: ufs: core: Fast-abort unsupported Query IDNs
scsi: ufs: core: Dynamically disable timestamp on unsupported devices

 drivers/ufs/core/ufshcd.c | 39 ++++++++++++++++++++++++++++++---------
 include/ufs/ufs.h         |  1 +
 2 files changed, 31 insertions(+), 9 deletions(-)
Signature · 1 line
2.55.0.1007.g17ff1f9808-goog